Skip to content

Commit 92584b6

Browse files
fix(meta): fix trivial move failed because of no member table ids (risingwavelabs#8725)
Signed-off-by: Little-Wallace <[email protected]>
1 parent 1df800a commit 92584b6

File tree

1 file changed

+8
-8
lines changed
  • src/meta/src/hummock/manager

1 file changed

+8
-8
lines changed

src/meta/src/hummock/manager/mod.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -822,6 +822,12 @@ where
822822
Some(task) => task,
823823
};
824824
compact_task.watermark = watermark;
825+
compact_task.existing_table_ids = current_version
826+
.levels
827+
.get(&compaction_group_id)
828+
.unwrap()
829+
.member_table_ids
830+
.clone();
825831

826832
if CompactStatus::is_trivial_move_task(&compact_task) && can_trivial_move {
827833
compact_task.sorted_output_ssts = compact_task.input_ssts[0].table_infos.clone();
@@ -838,13 +844,6 @@ where
838844
start_time.elapsed()
839845
);
840846
} else {
841-
// to get all relational table_id from sst_info
842-
compact_task.existing_table_ids = current_version
843-
.levels
844-
.get(&compaction_group_id)
845-
.unwrap()
846-
.member_table_ids
847-
.clone();
848847
compact_task.table_options = table_id_to_option
849848
.into_iter()
850849
.filter_map(|(table_id, table_option)| {
@@ -1142,6 +1141,7 @@ where
11421141
}
11431142
}
11441143
let is_success = if let TaskStatus::Success = compact_task.task_status() {
1144+
// if member_table_ids changes, the data of sstable may stale.
11451145
let is_expired = current_version
11461146
.levels
11471147
.get(&compact_task.compaction_group_id)
@@ -1987,7 +1987,7 @@ where
19871987
.scale_compactor_core_num
19881988
.set(suggest_scale_out_core as i64);
19891989

1990-
tracing::info!(
1990+
tracing::debug!(
19911991
"report_scale_compactor_info {:?} suggest_scale_out_core {:?}",
19921992
info,
19931993
suggest_scale_out_core

0 commit comments

Comments
 (0)