fix: ensure file deleted before database record remove (#18)

SamYSF · web-flow · commit 4fb0d000c273 · 2024-09-19T15:52:45.000+08:00
diff --git a/pkg/server.go b/pkg/server.go
@@ -402,12 +402,11 @@ func (s *dbserver) DeleteHistoryTestCase(ctx context.Context, historyTestCase *s
 	if strings.HasPrefix(fileName, "isFilePath-") {
 		tempDir := os.TempDir()
 		fullFilePath := filepath.Join(tempDir, fileName)
-
 		if err = os.Remove(fullFilePath); err != nil {
 			log.Printf("Failed to delete file: %s, error: %v\n", fullFilePath, err)
+			return
 		}
 	}
-
 	db.Delete(&historyTestResult)
 	return
 }
@@ -435,6 +434,7 @@ func (s *dbserver) DeleteAllHistoryTestCase(ctx context.Context, historyTestCase
 
 			if err = os.Remove(fullFilePath); err != nil {
 				log.Printf("Failed to delete file: %s, error: %v\n", fullFilePath, err)
+				continue
 			}
 		}
 		db.Delete(&historyTestResult)

Original file line number	Diff line number	Diff line change
`@@ -402,12 +402,11 @@ func (s dbserver) DeleteHistoryTestCase(ctx context.Context, historyTestCase s`
`402`	`402`	`if strings.HasPrefix(fileName, "isFilePath-") {`
`403`	`403`	`tempDir := os.TempDir()`
`404`	`404`	`fullFilePath := filepath.Join(tempDir, fileName)`
`405`		`-`
`406`	`405`	`if err = os.Remove(fullFilePath); err != nil {`
`407`	`406`	`log.Printf("Failed to delete file: %s, error: %v\n", fullFilePath, err)`
	`407`	`+ return`
`408`	`408`	`}`
`409`	`409`	`}`
`410`		`-`
`411`	`410`	`db.Delete(&historyTestResult)`
`412`	`411`	`return`
`413`	`412`	`}`
`@@ -435,6 +434,7 @@ func (s *dbserver) DeleteAllHistoryTestCase(ctx context.Context, historyTestCase`
`435`	`434`
`436`	`435`	`if err = os.Remove(fullFilePath); err != nil {`
`437`	`436`	`log.Printf("Failed to delete file: %s, error: %v\n", fullFilePath, err)`
	`437`	`+ continue`
`438`	`438`	`}`
`439`	`439`	`}`
`440`	`440`	`db.Delete(&historyTestResult)`