Skip to content

Commit 26b276c

Browse files
authored
chore: improve code lines (#28)
Co-authored-by: Rick <[email protected]>
1 parent 157edff commit 26b276c

File tree

3 files changed

+29
-17
lines changed

3 files changed

+29
-17
lines changed

e2e/compose.yaml

+8-1
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,16 @@ services:
4040
interval: 3s
4141
timeout: 60s
4242
retries: 10
43-
start_period: 3s
4443
ports:
4544
- "3306:3306"
4645

46+
tdengine:
47+
image: tdengine/tdengine:3.3.5.8
48+
environment:
49+
TAOS_ROOT_PASSWORD: "root"
50+
ports:
51+
- "6030:6030" # REST API port
52+
- "6031:6031" # client port
53+
- "6041:6041" # cluster port
4754
volumes:
4855
cache:

pkg/server.go

+6-16
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
Copyright 2023-2024 API Testing Authors.
2+
Copyright 2023-2025 API Testing Authors.
33
44
Licensed under the Apache License, Version 2.0 (the "License");
55
you may not use this file except in compliance with the License.
@@ -55,6 +55,9 @@ func createDB(user, password, address, database, driver string) (db *gorm.DB, er
5555
var dsn string
5656
switch driver {
5757
case "mysql", "":
58+
if !strings.Contains(address, ":") {
59+
address = fmt.Sprintf("%s:%d", address, 3306)
60+
}
5861
dsn = fmt.Sprintf("%s:%s@tcp(%s)/%s?charset=utf8mb4&parseTime=true", user, password, address, database)
5962
dialector = mysql.Open(dsn)
6063
case "sqlite":
@@ -93,8 +96,8 @@ func createDB(user, password, address, database, driver string) (db *gorm.DB, er
9396
return
9497
}
9598

96-
var dbCache map[string]*gorm.DB = make(map[string]*gorm.DB)
97-
var dbNameCache map[string]string = make(map[string]string)
99+
var dbCache = make(map[string]*gorm.DB)
100+
var dbNameCache = make(map[string]string)
98101

99102
func (s *dbserver) getClientWithDatabase(ctx context.Context, dbName string) (db *gorm.DB, err error) {
100103
store := remote.GetStoreFromContext(ctx)
@@ -191,19 +194,6 @@ func (s *dbserver) GetTestSuite(ctx context.Context, suite *remote.TestSuite) (r
191194
return
192195
}
193196

194-
func (s *dbserver) GetHistoryTestSuite(ctx context.Context, suite *remote.HistoryTestSuite) (reply *remote.HistoryTestSuite, err error) {
195-
query := &HistoryTestResult{}
196-
var db *gorm.DB
197-
if db, err = s.getClient(ctx); err != nil {
198-
return
199-
}
200-
201-
if err = db.Find(&query, nameQuery, suite.HistorySuiteName).Error; err == nil {
202-
reply = ConvertToGRPCHistoryTestSuite(query)
203-
}
204-
return
205-
}
206-
207197
func (s *dbserver) UpdateTestSuite(ctx context.Context, suite *remote.TestSuite) (reply *remote.TestSuite, err error) {
208198
reply = &remote.TestSuite{}
209199
input := ConvertToDBTestSuite(suite)

pkg/server_test.go

+15
Original file line numberDiff line numberDiff line change
@@ -323,3 +323,18 @@ func TestSQLite(t *testing.T) {
323323
assert.NoError(t, err)
324324
})
325325
}
326+
327+
func TestTdEngine(t *testing.T) {
328+
remoteServer := NewRemoteServer(10)
329+
assert.NotNil(t, remoteServer)
330+
defaultCtx := remote.WithIncomingStoreContext(context.TODO(), &atest.Store{
331+
URL: "127.0.0.1:6041",
332+
Username: "root",
333+
Password: "taosdata",
334+
Properties: map[string]string{
335+
"driver": "tdengine",
336+
},
337+
})
338+
_, err := remoteServer.Query(defaultCtx, &server.DataQuery{})
339+
assert.Error(t, err)
340+
}

0 commit comments

Comments
 (0)