Skip to content

Commit 7a6d39f

Browse files
Merge pull request #531 from Leonidas-from-XIV/node-4
Restore Node 4 compatibility temporarily
2 parents 5b11691 + c62b085 commit 7a6d39f

File tree

6 files changed

+141
-13
lines changed

6 files changed

+141
-13
lines changed

.travis.yml

+2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
language: node_js
22

33
node_js:
4+
- "4"
5+
- "6"
46
- "8"
57
- "10"
68
- "12"

lib/parser.js

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

+128-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@
7575
},
7676
"dependencies": {
7777
"sax": ">=0.6.0",
78-
"xmlbuilder": "~13.0.0"
78+
"xmlbuilder": "~11.0.0",
79+
"util.promisify": "~1.0.0"
7980
},
8081
"devDependencies": {
8182
"coffee-script": ">=1.10.0",
@@ -86,7 +87,7 @@
8687
"zap": ">=0.2.9"
8788
},
8889
"engines": {
89-
"node": ">=8.0.0"
90+
"node": ">=4.0.0"
9091
},
9192
"license": "MIT"
9293
}

src/parser.coffee

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22

33
sax = require 'sax'
44
events = require 'events'
5-
util = require 'util'
65
bom = require './bom'
76
processors = require './processors'
87
setImmediate = require('timers').setImmediate
98
defaults = require('./defaults').defaults
9+
promisify = require 'util.promisify'
1010

1111
# Underscore has a nice function for this, but we try to go without dependencies
1212
isEmpty = (thing) ->
@@ -255,7 +255,7 @@ class exports.Parser extends events
255255
throw err
256256

257257
parseStringPromise: (str) =>
258-
util.promisify(@parseString) str
258+
promisify(@parseString) str
259259

260260
exports.parseString = (str, a, b) ->
261261
# let's determine what we got as arguments

test/parser.test.coffee

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ util = require 'util'
55
assert = require 'assert'
66
path = require 'path'
77
os = require 'os'
8-
util = require 'util'
8+
promisify = require 'util.promisify'
99

1010
fileName = path.join __dirname, '/fixtures/sample.xml'
1111

12-
readFilePromise = util.promisify fs.readFile
12+
readFilePromise = promisify fs.readFile
1313

1414
skeleton = (options, checks) ->
1515
(test) ->

0 commit comments

Comments
 (0)