Also for comments

Author: Nutomic

crates/api_common/src/build_response.rs

@@ -228,7 +228,10 @@ pub async fn send_local_notifs(
       .is_err();
 
       // Don't send a notif to yourself
-      if parent_comment.creator_id != person.id && !check_blocks {
+      if parent_comment.creator_id != person.id
+        && !check_blocks
+        && !parent_comment.disable_reply_notifications
+      {
         let user_view = LocalUserView::read_person(&mut context.pool(), parent_creator_id).await;
         if let Ok(parent_user_view) = user_view {
           // Don't duplicate notif if already mentioned by checking recipient ids

crates/api_common/src/comment.rs

@@ -18,6 +18,9 @@ pub struct CreateComment {
   pub parent_id: Option<CommentId>,
   #[cfg_attr(feature = "full", ts(optional))]
   pub language_id: Option<LanguageId>,
+  /// If false the author doesnt get notified about new replies
+  #[cfg_attr(feature = "full", ts(optional))]
+  pub disable_reply_notifications: Option<bool>,
 }
 
 #[skip_serializing_none]
@@ -40,6 +43,8 @@ pub struct EditComment {
   pub content: Option<String>,
   #[cfg_attr(feature = "full", ts(optional))]
   pub language_id: Option<LanguageId>,
+  #[cfg_attr(feature = "full", ts(optional))]
+  pub disable_reply_notifications: Option<bool>,
 }
 
 #[skip_serializing_none]

crates/api_common/src/post.rs

@@ -40,7 +40,7 @@ pub struct CreatePost {
   /// Time when this post should be scheduled. Null means publish immediately.
   #[cfg_attr(feature = "full", ts(optional))]
   pub scheduled_publish_time: Option<i64>,
-  /// True if the post creator gets notified about new top-level comments
+  /// If false the post creator doesnt get notified about new top-level comments
   #[cfg_attr(feature = "full", ts(optional))]
   pub disable_reply_notifications: Option<bool>,
 }

crates/api_crud/src/comment/create.rs

@@ -100,6 +100,7 @@ pub async fn create_comment(
   let mut comment_form = CommentInsertForm {
     language_id: Some(language_id),
     federation_pending: Some(community_use_pending(&post_view.community, &context).await),
+    disable_reply_notifications: data.disable_reply_notifications,
     ..CommentInsertForm::new(local_user_view.person.id, data.post_id, content.clone())
   };
   comment_form = plugin_hook_before("before_create_local_comment", comment_form).await?;

crates/api_crud/src/comment/update.rs

@@ -67,6 +67,7 @@ pub async fn update_comment(
   let mut form = CommentUpdateForm {
     content,
     language_id: Some(language_id),
+    disable_reply_notifications: data.disable_reply_notifications,
     updated: Some(Some(Utc::now())),
     ..Default::default()
   };

crates/apub/src/objects/comment.rs

@@ -212,6 +212,7 @@ impl Object for ApubComment {
       local: Some(false),
       language_id,
       federation_pending: Some(false),
+      disable_reply_notifications: None,
     };
     form = plugin_hook_before("before_receive_federated_comment", form).await?;
     let parent_comment_path = parent_comment.map(|t| t.0.path);

crates/db_schema/src/impls/comment.rs

@@ -347,6 +347,7 @@ mod tests {
       report_count: 0,
       unresolved_report_count: 0,
       federation_pending: false,
+      disable_reply_notifications: false,
     };
 
     let child_comment_form = CommentInsertForm::new(

crates/db_schema/src/source/comment.rs

@@ -63,6 +63,8 @@ pub struct Comment {
   /// If a local user comments in a remote community, the comment is hidden until it is confirmed
   /// accepted by the community (by receiving it back via federation).
   pub federation_pending: bool,
+  /// If false the author doesnt get notified about new replies
+  pub disable_reply_notifications: bool,
 }
 
 #[derive(Debug, Clone, derive_new::new)]
@@ -93,6 +95,8 @@ pub struct CommentInsertForm {
   pub language_id: Option<LanguageId>,
   #[new(default)]
   pub federation_pending: Option<bool>,
+  #[new(default)]
+  pub disable_reply_notifications: Option<bool>,
 }
 
 #[derive(Debug, Clone, Default)]
@@ -109,6 +113,7 @@ pub struct CommentUpdateForm {
   pub distinguished: Option<bool>,
   pub language_id: Option<LanguageId>,
   pub federation_pending: Option<bool>,
+  pub disable_reply_notifications: Option<bool>,
 }
 
 #[skip_serializing_none]

crates/db_schema/src/source/post.rs

@@ -94,7 +94,7 @@ pub struct Post {
   /// If a local user posts in a remote community, the comment is hidden until it is confirmed
   /// accepted by the community (by receiving it back via federation).
   pub federation_pending: bool,
-  /// True if the post creator gets notified about new top-level comments
+  /// If false the post creator doesnt get notified about new top-level comments
   pub disable_reply_notifications: bool,
 }
 

crates/db_schema_file/src/schema.rs

@@ -139,6 +139,7 @@ diesel::table! {
         report_count -> Int2,
         unresolved_report_count -> Int2,
         federation_pending -> Bool,
+        disable_reply_notifications -> Bool
     }
 }
 

crates/db_views/src/utils.rs

@@ -180,6 +180,7 @@ pub(crate) fn comment_select_remove_deletes() -> _ {
     comment::report_count,
     comment::unresolved_report_count,
     comment::federation_pending,
+    comment::disable_reply_notifications,
   )
 }
 

migrations/2025-04-07-130702_disable-post-creator-notifications/down.sql

@@ -1 +1,5 @@
-alter table post drop column disable_reply_notifications;
+ALTER TABLE post
+    DROP COLUMN disable_reply_notifications;
+
+ALTER TABLE comment
+    DROP COLUMN disable_reply_notifications

migrations/2025-04-07-130702_disable-post-creator-notifications/up.sql

@@ -1 +1,6 @@
-alter table post add column disable_reply_notifications bool not null default false;
+ALTER TABLE post
+    ADD COLUMN disable_reply_notifications bool NOT NULL DEFAULT FALSE;
+
+ALTER TABLE comment
+    ADD COLUMN disable_reply_notifications bool NOT NULL DEFAULT FALSE;
+