Merge pull request #10571 from LedgerHQ/feat/swap-test-cases2

Feat/swap test cases2

Author: aabbas-ledger

apps/ledger-live-mobile/src/components/DeviceAction/rendering.tsx

@@ -286,7 +286,7 @@ export function renderConfirmSwap({
 
         <Flex justifyContent={"space-between"} width="100%">
           <FieldItem title={t("DeviceAction.swap2.amountSent")}>
-            <Text>
+            <Text testID="amountSent">
               <CurrencyUnitValue
                 value={transaction.amount}
                 unit={unitFrom}
@@ -297,7 +297,7 @@ export function renderConfirmSwap({
           </FieldItem>
 
           <FieldItem title={t("DeviceAction.swap2.amountReceived")}>
-            <Text>
+            <Text testID="amountReceived">
               <CurrencyUnitValue
                 unit={unitTo}
                 value={amountExpectedTo ? new BigNumber(amountExpectedTo) : null}
@@ -313,12 +313,12 @@ export function renderConfirmSwap({
                 <ProviderIcon size="XXS" name={provider} />
               </Flex>
 
-              <Text>{providerName}</Text>
+              <Text testID="provider">{providerName}</Text>
             </Flex>
           </FieldItem>
 
           <FieldItem title={t("DeviceAction.swap2.fees")}>
-            <Text>
+            <Text testID="fees">
               <CurrencyUnitValue
                 unit={getFeesUnit(
                   getFeesCurrency(getMainAccount(exchange.fromAccount, exchange.fromParentAccount)),
@@ -333,14 +333,18 @@ export function renderConfirmSwap({
           <FieldItem title={t("DeviceAction.swap2.sourceAccount")}>
             <Flex flexDirection="row" alignItems="center">
               <CurrencyIcon size={20} currency={getAccountCurrency(exchange.fromAccount)} />
-              <Text marginLeft={2}>{fromAccountName}</Text>
+              <Text marginLeft={2} testID="sourceAccount">
+                {fromAccountName}
+              </Text>
             </Flex>
           </FieldItem>
 
           <FieldItem title={t("DeviceAction.swap2.targetAccount")}>
             <Flex flexDirection="row" alignItems="center">
               <CurrencyIcon size={20} currency={getAccountCurrency(exchange.toAccount)} />
-              <Text marginLeft={2}>{toAccountName}</Text>
+              <Text marginLeft={2} testID="targetAccount">
+                {toAccountName}
+              </Text>
             </Flex>
           </FieldItem>
         </Flex>

e2e/mobile/helpers/elementHelpers.ts

@@ -222,9 +222,10 @@ export const WebElementHelpers = {
   },
 
   getWebElementsByIdAndText(id: string, text: string, index = 0): WebElement {
-    const base = web.element(
-      by.web.xpath(`//span[@data-testid="${id}" and text()="${text}"]`),
-    ) as IndexedWebElement;
+    const xpath = id
+      ? `//span[@data-testid="${id}" and text()="${text}"]`
+      : `//span[text()="${text}"]`;
+    const base = web.element(by.web.xpath(xpath)) as IndexedWebElement;
     return index > 0 ? base.atIndex(index) : base;
   },
 

e2e/mobile/page/liveApps/swapLiveApp.ts

@@ -1,7 +1,7 @@
 import { Provider } from "@ledgerhq/live-common/e2e/enum/Provider";
 import { allure } from "jest-allure2-reporter/api";
 import { getMinimumSwapAmount } from "@ledgerhq/live-common/e2e/swap";
-import { SwapType } from "@ledgerhq/live-common/e2e/models/Swap";
+import { Account } from "@ledgerhq/live-common/e2e/enum/Account";
 
 export default class SwapLiveAppPage {
   fromSelector = "from-account-coin-selector";
@@ -14,6 +14,10 @@ export default class SwapLiveAppPage {
   quoteProviderName = "quote-card-provider-name";
   executeSwapButton = "execute-button";
   deviceActionErrorDescriptionId = "error-description-deviceAction";
+  fromAccountErrorId = "from-account-error";
+  showDetailslink = "show-details-link";
+  quotesContainerErrorIcon = "quotes-container-error-icon";
+  insufficientFundsBuyButton = "insufficient-funds-buy-button";
 
   @Step("Wait for swap live app")
   async waitForSwapLiveApp() {
@@ -52,6 +56,11 @@ export default class SwapLiveAppPage {
     await waitWebElementByTestId(this.numberOfQuotes);
   }
 
+  @Step("verify quotes are displayed")
+  async checkQuotes() {
+    await detoxExpect(getWebElementByTestId(this.numberOfQuotes)).toExist();
+  }
+
   @Step("Select available provider")
   async selectExchange() {
     let index = 0;
@@ -82,10 +91,8 @@ export default class SwapLiveAppPage {
   }
 
   @Step("Get minimum amount for swap")
-  async getMinimumAmount(swap: SwapType) {
-    return (
-      (await getMinimumSwapAmount(swap.accountToDebit, swap.accountToCredit))?.toString() ?? ""
-    );
+  async getMinimumAmount(fromAccount: Account, toAccount: Account) {
+    return (await getMinimumSwapAmount(fromAccount, toAccount))?.toString() ?? "";
   }
 
   @Step("Get provider list")
@@ -136,7 +143,7 @@ export default class SwapLiveAppPage {
     await this.checkExchangeButtonHasProviderName(providerList[0]);
   }
 
-  @Step("Check exchange button has provider name")
+  @Step("Check exchange button has provider name: $0")
   async checkExchangeButtonHasProviderName(provider: string) {
     const expectedButtonText = [
       Provider.ONE_INCH.uiName,
@@ -192,4 +199,24 @@ export default class SwapLiveAppPage {
     }
     return quotes;
   }
+
+  @Step("Verify swap amount error message match: $0")
+  async verifySwapAmountErrorMessageIsCorrect(expectedMessage: string | RegExp) {
+    await waitWebElementByTestId(this.fromAccountErrorId);
+    const errorText: string = await getWebElementText(this.fromAccountErrorId);
+    if (typeof expectedMessage === "string") {
+      jestExpect(errorText).toContain(expectedMessage);
+    } else if (expectedMessage instanceof RegExp) {
+      jestExpect(errorText).toMatch(expectedMessage);
+    }
+  }
+
+  @Step("Verify swap CTA banner displayed")
+  async checkCtaBanner() {
+    await waitWebElementByTestId(this.showDetailslink);
+    const showDetailsLink = getWebElementByTestId(this.showDetailslink);
+    await showDetailsLink.runScript("(el) => el.click()");
+    await detoxExpect(getWebElementByTestId(this.quotesContainerErrorIcon)).toExist();
+    await detoxExpect(getWebElementByTestId(this.insufficientFundsBuyButton)).toExist();
+  }
 }

e2e/mobile/page/speculos.page.ts

@@ -6,11 +6,13 @@ import {
   signDelegationTransaction,
   signSendTransaction,
   verifyAmountsAndAcceptSwap,
+  verifyAmountsAndRejectSwap,
 } from "@ledgerhq/live-common/e2e/speculos";
 import { TransactionType } from "@ledgerhq/live-common/e2e/models/Transaction";
 import { DelegateType } from "@ledgerhq/live-common/e2e/models/Delegate";
 import { AccountType } from "@ledgerhq/live-common/e2e/enum/Account";
 import { SwapType } from "@ledgerhq/live-common/e2e/models/Swap";
+import { Account } from "@ledgerhq/live-common/e2e/enum/Account";
 
 export default class SpeculosPage {
   @Step("Verify receive address correctness on device")
@@ -43,9 +45,21 @@ export default class SpeculosPage {
     await verifyAmountsAndAcceptSwap(swap, amount);
   }
 
-  async setExchangeDependencies(swap: SwapType) {
+  @Step("Verify amounts and reject swap")
+  async verifyAmountsAndRejectSwap(swap: SwapType, amount: string) {
+    await verifyAmountsAndRejectSwap(swap, amount);
+  }
+
+  async setExchangeDependencies(swapOrFromAccount: SwapType | Account, toAccount?: Account) {
+    let accounts: Account[];
+    if (toAccount) {
+      accounts = [swapOrFromAccount as Account, toAccount];
+    } else {
+      const swap = swapOrFromAccount as SwapType;
+      accounts = [swap.accountToDebit, swap.accountToCredit];
+    }
     setExchangeDependencies(
-      [swap.accountToDebit, swap.accountToCredit].map(acc => ({
+      accounts.map(acc => ({
         name: acc.currency.speculosApp.name.replace(/ /g, "_"),
       })),
     );

e2e/mobile/page/trade/swap.page.ts

@@ -1,13 +1,17 @@
-import { getMinimumSwapAmount } from "@ledgerhq/live-common/lib/e2e/swap";
 import { delay, isIos, isSpeculosRemote, openDeeplink } from "../../helpers/commonHelpers";
 import { SwapType } from "@ledgerhq/live-common/e2e/models/Swap";
-import { Account } from "@ledgerhq/live-common/e2e/enum/Account";
 
 export default class SwapPage {
   baseLink = "swap";
   confirmSwapOnDeviceDrawerId = "confirm-swap-on-device";
   swapSuccessTitleId = "swap-success-title";
   deviceActionLoading = "device-action-loading";
+  amountReceived = "amountReceived";
+  fees = "fees";
+  amountSent = "amountSent";
+  sourceAccount = "sourceAccount";
+  targetAccount = "targetAccount";
+  swapProvider = "provider";
 
   swapFormTab = () => getElementById("swap-form-tab");
 
@@ -30,6 +34,14 @@ export default class SwapPage {
     await waitForElementNotVisible(this.deviceActionLoading);
   }
 
+  @Step("Verify the amounts and reject swap")
+  async verifyAmountsAndRejectSwap(swap: SwapType, amount: string) {
+    await waitForElementById(this.confirmSwapOnDeviceDrawerId);
+    await app.speculos.verifyAmountsAndRejectSwap(swap, amount);
+    await this.delayDeviceActionLoadingCheck();
+    await waitForElementNotVisible(this.deviceActionLoading);
+  }
+
   @Step("Wait for swap success and continue")
   async waitForSuccessAndContinue() {
     await waitForElementById(this.swapSuccessTitleId);
@@ -40,8 +52,42 @@ export default class SwapPage {
     await delay(isSpeculosRemote() && isIos() ? 45_000 : 20_000);
   }
 
-  @Step("Check minimum amount for swap")
-  async getMinimumAmount(accountFrom: Account, accountTo: Account) {
-    return (await getMinimumSwapAmount(accountFrom, accountTo))?.toString() ?? "";
+  @Step("Get amount to receive")
+  async getAmountToReceive() {
+    return (await getTextOfElement(this.amountReceived)).trim();
+  }
+
+  @Step("Get fees")
+  async getFees() {
+    return (await getTextOfElement(this.fees)).trim();
+  }
+
+  @Step("Verify amount to receive: $0")
+  async verifyAmountToReceive(amount: string) {
+    const received = (await getTextOfElement(this.amountReceived)).replace(/\s/g, "");
+    const expected = amount.replace(/\s/g, "");
+    jestExpect(received).toBe(expected);
+  }
+
+  @Step("Verify amount to send: $0 $1")
+  async verifyAmountSent(amount: string, currency: string) {
+    const received = (await getTextOfElement(this.amountSent)).replace(/\s/g, "");
+    const expected = `${amount} ${currency}`.replace(/\s/g, "");
+    jestExpect(received).toBe(expected);
+  }
+
+  @Step("Verify source currency: $0")
+  async verifySourceAccount(sourceCurrency: string) {
+    jestExpect((await getTextOfElement(this.sourceAccount)).trim()).toMatch(sourceCurrency);
+  }
+
+  @Step("Verify target currency: $0")
+  async verifyTargetCurrency(targetCurrency: string) {
+    jestExpect((await getTextOfElement(this.targetAccount)).trim()).toMatch(targetCurrency);
+  }
+
+  @Step("Verify provider: $0")
+  async verifyProvider(provider: string) {
+    jestExpect((await getTextOfElement(this.swapProvider)).trim()).toMatch(provider);
   }
 }