Skip to content

Commit 7fc1b94

Browse files
Merge pull request #10457 from LedgerHQ/fix/live-19305/analytics-tracking-live-app
fix(live-19305): add analytics sharing flag to swap webviews
2 parents c7cd3dc + fb242c9 commit 7fc1b94

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

.changeset/wild-ties-drum.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"ledger-live-desktop": minor
3+
"live-mobile": minor
4+
---
5+
6+
Include shareAnalytics flag in both mobile and desktop swap webviews to track user consent for analytics

apps/ledger-live-desktop/src/renderer/screens/exchange/Swap2/Form/SwapWebViewDemo3.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ import {
4343
enablePlatformDevToolsSelector,
4444
languageSelector,
4545
lastSeenDeviceSelector,
46+
shareAnalyticsSelector,
4647
} from "~/renderer/reducers/settings";
4748
import { walletSelector } from "~/renderer/reducers/wallet";
4849
import { captureException } from "~/sentry/renderer";
@@ -125,6 +126,7 @@ const SwapWebView = ({ manifest }: SwapWebProps) => {
125126
const fiatCurrency = useSelector(counterValueCurrencySelector);
126127
const locale = useSelector(languageSelector);
127128
const lastSeenDevice = useSelector(lastSeenDeviceSelector);
129+
const shareAnalytics = useSelector(shareAnalyticsSelector);
128130
const currentVersion = __APP_VERSION__;
129131
const enablePlatformDevTools = useSelector(enablePlatformDevToolsSelector);
130132
const devMode = useSelector(developerModeSelector);
@@ -513,6 +515,7 @@ const SwapWebView = ({ manifest }: SwapWebProps) => {
513515
lastSeenDevice: lastSeenDevice?.modelId,
514516
currentVersion,
515517
platform: "LLD",
518+
shareAnalytics,
516519
}}
517520
onStateChange={onStateChange}
518521
ref={webviewAPIRef}

apps/ledger-live-mobile/src/screens/Swap/LiveApp/WebView.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import { WebviewState } from "~/components/Web3AppWebview/types";
1212
import { getCountryLocale } from "~/helpers/getStakeLabelLocaleBased";
1313
import { useSettings } from "~/hooks";
1414
import {
15+
analyticsEnabledSelector,
1516
counterValueCurrencySelector,
1617
exportSettingsSelector,
1718
lastSeenDeviceSelector,
@@ -41,6 +42,7 @@ export function WebView({ manifest, params, setWebviewState }: Props) {
4142
const SWAP_API_BASE = useEnv("SWAP_API_BASE");
4243
const SWAP_USER_IP = useEnv("SWAP_USER_IP");
4344
const exportSettings = useSelector(exportSettingsSelector);
45+
const shareAnalytics = useSelector(analyticsEnabledSelector).toString();
4446
const devMode = exportSettings.developerModeEnabled.toString();
4547
const lastSeenDevice = useSelector(lastSeenDeviceSelector);
4648

@@ -68,6 +70,7 @@ export function WebView({ manifest, params, setWebviewState }: Props) {
6870
lastSeenDevice: lastSeenDevice?.modelId,
6971
OS: Platform.OS,
7072
platform: "LLM", // need consistent format with LLD, Platform doesn't work
73+
shareAnalytics,
7174
...swapParams,
7275
}}
7376
/>

0 commit comments

Comments
 (0)