fix: Electron IPC serializer issue on certain logs

Now manually JSON.stringify logs from the renderer thread
before sending them to the main thread

Author: alexandremgo

apps/ledger-live-desktop/src/main/setup.ts

@@ -33,10 +33,21 @@ ipcMain.on("updater", (e, type) => {
  */
 ipcMain.handle(
   "save-logs",
-  async (_event, path: Electron.SaveDialogReturnValue, rendererLogs: unknown[]) => {
+  async (_event, path: Electron.SaveDialogReturnValue, rendererLogsStr: string) => {
     if (!path.canceled && path.filePath) {
       const inMemoryLogger = InMemoryLogger.getLogger();
       const internalLogs = inMemoryLogger.getLogs();
+
+      // The deserialization would have been done internally by electron if `rendererLogs` was passed directly as a JS object/array.
+      // But it avoids certain issues with the serialization/deserialization done by electron.
+      let rendererLogs: unknown[] = [];
+      try {
+        rendererLogs = JSON.parse(rendererLogsStr) as unknown[];
+      } catch (error) {
+        console.error("Error while parsing logs from the renderer thread", error);
+        return;
+      }
+
       console.log(
         `Saving ${rendererLogs.length} logs from the renderer thread and ${internalLogs.length} logs from the internal thread`,
       );

apps/ledger-live-desktop/src/renderer/components/ExportLogsButton.tsx

@@ -13,8 +13,17 @@ import Button, { Props as ButtonProps } from "~/renderer/components/Button";
 import { accountsSelector } from "~/renderer/reducers/accounts";
 
 const saveLogs = async (path: Electron.SaveDialogReturnValue) => {
-  // Requests the main thread to save logs in a file
-  await ipcRenderer.invoke("save-logs", path, memoryLogger.getMemoryLogs());
+  const memoryLogs = memoryLogger.getMemoryLogs();
+
+  try {
+    // Serializes ourself with `stringify` to avoid "object could not be cloned" errors from the electron IPC serializer.
+    const memoryLogsStr = JSON.stringify(memoryLogs, null, 2);
+
+    // Requests the main thread to save logs in a file
+    await ipcRenderer.invoke("save-logs", path, memoryLogsStr);
+  } catch (error) {
+    console.error("Error while requesting to save logs from the renderer thread", error);
+  }
 };
 
 type RestProps = ButtonProps & {