Skip to content

Document the signing behavior from version 2.4.0 #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bigspider opened this issue Jun 4, 2025 · 0 comments
Open

Document the signing behavior from version 2.4.0 #330

bigspider opened this issue Jun 4, 2025 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@bigspider
Copy link
Collaborator

Since version 2.4.0, the app has a fine-grained signing behavior, allowing to avoid signing unnecessarily for all possible spending paths if only some are present. This should be better documented.

For MuSig2, the app's decisions are affected by the presence of pubnonces, and this might not match the expectations of people working with the PSBT signing flow of musig (particularly, the app assumes Round 2 if any pubnonce is present in the PSBT.

TBD if we also want to modify the client libraries to handle this more gracefully (e.g.: if some pubnonces are present, but not all - then strip all of them, so the app proceeds to Round 1 instead of returning an error later).

@bigspider bigspider added the documentation Improvements or additions to documentation label Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant