Skip to content

Spool Manager overlaps panel below #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Xiondewah opened this issue May 27, 2021 · 8 comments
Closed

Spool Manager overlaps panel below #157

Xiondewah opened this issue May 27, 2021 · 8 comments
Labels
wontfix This will not be worked on

Comments

@Xiondewah
Copy link

Updated to 0.1.5.9 which has fixed the layout of the edit/add spool manager - so thanks - but still have the problem where spool manager ui overlaps any panel below (so I've had to position it at the bottom of the left hand frame.

:-)

@LazeMSS
Copy link
Owner

LazeMSS commented May 27, 2021

Screenshot?

@Xiondewah
Copy link
Author

Sorry - forgot!
image

@LazeMSS
Copy link
Owner

LazeMSS commented May 27, 2021

Yes thats really not a bug in UI Customizer - that panel has a "nobr" tag - so the browser is told to never make linebreaks. This should be fixed in the spool manager plugin - no break is really no good for mobile/responsive layouts. As stated in OllisGit/OctoPrint-SpoolManager#142 I will try and do a bit of revamp of the UI together with OllisGit.

@LazeMSS LazeMSS added the wontfix This will not be worked on label May 27, 2021
@LazeMSS LazeMSS closed this as completed May 27, 2021
@Xiondewah
Copy link
Author

This is frustrating because I posted it on OllisGit's hub and he said it should be with you - but thanks, hopefully the 2 of you will be able to sort it out between you.

@OllisGit
Copy link

Hey @Xiondewah,

I closed your ticket, because it was duplicated. And I entered a link to the other ticket where LazeMSS is also involved in the discussion.
See your orig. Ticket: OllisGit/OctoPrint-SpoolManager#171

I never said that the issue must be solved by @LazeMSS !

@OllisGit
Copy link

Btw. the br-element will be removed in the next release.

@LazeMSS
Copy link
Owner

LazeMSS commented May 28, 2021

Hey @Xiondewah,

I closed your ticket, because it was duplicated. And I entered a link to the other ticket where LazeMSS is also involved in the discussion.
See your orig. Ticket: OllisGit/OctoPrint-SpoolManager#171

I never said that the issue must be solved by @LazeMSS !

No panic @OllisGit we will work out a good solution together ;)

@Xiondewah
Copy link
Author

Thank you both - the two plugins are so useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants