Skip to content

Commit 5a58a46

Browse files
author
MarcoFalke
committed
Merge bitpay#21: Remove hand-coded UniValue destructor.
b4cdfc4 Remove hand-coded UniValue destructor. (Martin Ankerl) Pull request description: When the hand-written destructor is removed, the compiler will automatically create a proper one, with correct `noexcept`. This allows `std::vector<UniValue>` to be resized without having to copy all elements first, which makes JSON generation of a bitcoin block (as in the benchmark "BlockToJsonVerbose") 25% faster on my machine. Top commit has no ACKs. Tree-SHA512: a4a5a352d946e795b7d78b98b781969caa103acb19770d22d62efd16f42b2845c476dee57df729e983018e065e3b450f3f1e3c95cf68b2f359ee4ca24fba217f
2 parents 7fba60b + b4cdfc4 commit 5a58a46

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

include/univalue.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ class UniValue {
4747
std::string s(val_);
4848
setStr(s);
4949
}
50-
~UniValue() {}
5150

5251
void clear();
5352

0 commit comments

Comments
 (0)