Skip to content

Commit 501203a

Browse files
author
MarcoFalke
committed
Merge bitcoin-core/gui#17: doc: Remove outdated comment in TransactionTablePriv
faebb60 doc: Remove outdated comment in TransactionTablePriv (MarcoFalke) Pull request description: Locks are no longer taken upfront, so remove the outdated comment ACKs for top commit: hebasto: ACK faebb60, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: cd6df24d49d17e58049ac9b261c5e07c8e85ed1aacb547b13c0e55139339d7fcc3b1f766ea2e27d758ea77deadc01f7e28781be1515323c82b9012cee8fd488b
2 parents 01f857a + faebb60 commit 501203a

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

src/qt/transactiontablemodel.cpp

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -178,17 +178,12 @@ class TransactionTablePriv
178178

179179
TransactionRecord* index(interfaces::Wallet& wallet, const uint256& cur_block_hash, const int idx)
180180
{
181-
if(idx >= 0 && idx < cachedWallet.size())
182-
{
181+
if (idx >= 0 && idx < cachedWallet.size()) {
183182
TransactionRecord *rec = &cachedWallet[idx];
184183

185-
// Get required locks upfront. This avoids the GUI from getting
186-
// stuck if the core is holding the locks for a longer time - for
187-
// example, during a wallet rescan.
188-
//
189184
// If a status update is needed (blocks came in since last check),
190-
// update the status of this transaction from the wallet. Otherwise,
191-
// simply re-use the cached status.
185+
// try to update the status of this transaction from the wallet.
186+
// Otherwise, simply re-use the cached status.
192187
interfaces::WalletTxStatus wtx;
193188
int numBlocks;
194189
int64_t block_time;

0 commit comments

Comments
 (0)