[GetTransaction] remove unneeded cs_main lock acquire

theStack · theStack · commit 4a1b2a7ba7f8 · 2021-08-02T18:31:02.000+02:00
diff --git a/src/node/transaction.cpp b/src/node/transaction.cpp
@@ -125,8 +125,6 @@ TransactionError BroadcastTransaction(NodeContext& node, const CTransactionRef t
 
 CTransactionRef GetTransaction(const CBlockIndex* const block_index, const CTxMemPool* const mempool, const uint256& hash, const Consensus::Params& consensusParams, uint256& hashBlock)
 {
-    LOCK(cs_main);
-
     if (mempool && !block_index) {
         CTransactionRef ptx = mempool->get(hash);
         if (ptx) return ptx;

Original file line number	Diff line number	Diff line change
`@@ -125,8 +125,6 @@ TransactionError BroadcastTransaction(NodeContext& node, const CTransactionRef t`
`125`	`125`
`126`	`126`	`CTransactionRef GetTransaction(const CBlockIndex* const block_index, const CTxMemPool* const mempool, const uint256& hash, const Consensus::Params& consensusParams, uint256& hashBlock)`
`127`	`127`	`{`
`128`		`- LOCK(cs_main);`
`129`		`-`
`130`	`128`	`if (mempool && !block_index) {`
`131`	`129`	`CTransactionRef ptx = mempool->get(hash);`
`132`	`130`	`if (ptx) return ptx;`