Skip to content

Commit dc1bb09

Browse files
authored
Fix a bunch of stuff that should have been marked 'inline' (#223)
1 parent 4f84b63 commit dc1bb09

File tree

4 files changed

+21
-21
lines changed

4 files changed

+21
-21
lines changed

include/aluminum/traits/ht_traits.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
namespace Al {
4040

41-
template <> constexpr char AlBackendName<HostTransferBackend>[] = "ht";
41+
template <> inline constexpr char AlBackendName<HostTransferBackend>[] = "ht";
4242

4343
// Define the supported host-transfer operators.
4444
template <> struct IsOpSupported<AlOperation::allgather, HostTransferBackend> : std::true_type {};

include/aluminum/traits/mpi_traits.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
namespace Al {
4141

42-
template <> constexpr char AlBackendName<MPIBackend>[] = "mpi";
42+
template <> inline constexpr char AlBackendName<MPIBackend>[] = "mpi";
4343

4444
// Define the supported MPI operators.
4545
template <> struct IsOpSupported<AlOperation::allgather, MPIBackend> : std::true_type {};

include/aluminum/traits/nccl_traits.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
namespace Al {
4040

41-
template <> constexpr char AlBackendName<NCCLBackend>[] = "nccl";
41+
template <> inline constexpr char AlBackendName<NCCLBackend>[] = "nccl";
4242

4343
// Define the supported NCCL operators.
4444
template <> struct IsOpSupported<AlOperation::allgather, NCCLBackend> : std::true_type {};

include/aluminum/traits/traits_base.hpp

+18-18
Original file line numberDiff line numberDiff line change
@@ -63,24 +63,24 @@ enum class AlOperation {
6363

6464
/** Give a textual name for each operation. */
6565
template <AlOperation Op> constexpr char AlOperationName[] = "unknown";
66-
template <> constexpr char AlOperationName<AlOperation::allgather>[] = "allgather";
67-
template <> constexpr char AlOperationName<AlOperation::allgatherv>[] = "allgatherv";
68-
template <> constexpr char AlOperationName<AlOperation::allreduce>[] = "allreduce";
69-
template <> constexpr char AlOperationName<AlOperation::alltoall>[] = "alltoall";
70-
template <> constexpr char AlOperationName<AlOperation::alltoallv>[] = "alltoallv";
71-
template <> constexpr char AlOperationName<AlOperation::barrier>[] = "barrier";
72-
template <> constexpr char AlOperationName<AlOperation::bcast>[] = "bcast";
73-
template <> constexpr char AlOperationName<AlOperation::gather>[] = "gather";
74-
template <> constexpr char AlOperationName<AlOperation::gatherv>[] = "gatherv";
75-
template <> constexpr char AlOperationName<AlOperation::reduce>[] = "reduce";
76-
template <> constexpr char AlOperationName<AlOperation::reduce_scatter>[] = "reduce_scatter";
77-
template <> constexpr char AlOperationName<AlOperation::reduce_scatterv>[] = "reduce_scatterv";
78-
template <> constexpr char AlOperationName<AlOperation::scatter>[] = "scatter";
79-
template <> constexpr char AlOperationName<AlOperation::scatterv>[] = "scatterv";
80-
template <> constexpr char AlOperationName<AlOperation::send>[] = "send";
81-
template <> constexpr char AlOperationName<AlOperation::recv>[] = "recv";
82-
template <> constexpr char AlOperationName<AlOperation::sendrecv>[] = "sendrecv";
83-
template <> constexpr char AlOperationName<AlOperation::multisendrecv>[] = "multisendrecv";
66+
template <> inline constexpr char AlOperationName<AlOperation::allgather>[] = "allgather";
67+
template <> inline constexpr char AlOperationName<AlOperation::allgatherv>[] = "allgatherv";
68+
template <> inline constexpr char AlOperationName<AlOperation::allreduce>[] = "allreduce";
69+
template <> inline constexpr char AlOperationName<AlOperation::alltoall>[] = "alltoall";
70+
template <> inline constexpr char AlOperationName<AlOperation::alltoallv>[] = "alltoallv";
71+
template <> inline constexpr char AlOperationName<AlOperation::barrier>[] = "barrier";
72+
template <> inline constexpr char AlOperationName<AlOperation::bcast>[] = "bcast";
73+
template <> inline constexpr char AlOperationName<AlOperation::gather>[] = "gather";
74+
template <> inline constexpr char AlOperationName<AlOperation::gatherv>[] = "gatherv";
75+
template <> inline constexpr char AlOperationName<AlOperation::reduce>[] = "reduce";
76+
template <> inline constexpr char AlOperationName<AlOperation::reduce_scatter>[] = "reduce_scatter";
77+
template <> inline constexpr char AlOperationName<AlOperation::reduce_scatterv>[] = "reduce_scatterv";
78+
template <> inline constexpr char AlOperationName<AlOperation::scatter>[] = "scatter";
79+
template <> inline constexpr char AlOperationName<AlOperation::scatterv>[] = "scatterv";
80+
template <> inline constexpr char AlOperationName<AlOperation::send>[] = "send";
81+
template <> inline constexpr char AlOperationName<AlOperation::recv>[] = "recv";
82+
template <> inline constexpr char AlOperationName<AlOperation::sendrecv>[] = "sendrecv";
83+
template <> inline constexpr char AlOperationName<AlOperation::multisendrecv>[] = "multisendrecv";
8484

8585
/** Give a textual name for each backend. */
8686
template <typename Backend> constexpr char AlBackendName[] = "unknown";

0 commit comments

Comments
 (0)