Skip to content

Commit 40783d6

Browse files
authored
Merge pull request #2064 from hyperledger/maintainer_requirements
Update Maintainer status
2 parents 4aa96b5 + 9bb55bd commit 40783d6

File tree

2 files changed

+100
-11
lines changed

2 files changed

+100
-11
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
1111

1212
### Features
1313

14-
* bump snapshot version to 4.12.1 [#2058](https://github.com/web3j/web3j/pull/2058)
14+
* bump snapshot version to 4.12.1 [#2058](https://github.com/hyperledger/web3j/pull/2058)
15+
* Update maintainer requirements status [#2064](https://github.com/hyperledger/web3j/pull/2064)
1516

1617
### BREAKING CHANGES
1718

MAINTAINERS.md

Lines changed: 98 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
11
Maintainers
22
===========
3+
<!-- Please keep all lists sorted alphabetically by github -->
34

45
**Active Maintainers**
56

6-
| Name | GitHub | Chat |
7-
|----------------|--------|-----|
8-
| Conor Svensson | [conor10][conor10] | conor10 |
9-
| Andrii | [andrii-kl][andrii-kl] | andrii-kl |
10-
| George Ţebrean | [gtebrean][gtebrean] | gdev#2230 |
11-
| Nischal Sharma | [NickSneo][NickSneo] | nicks1106 |
12-
7+
<!-- web3j-maintainers group has maintainer access to web3j repo -->
138

9+
| Name | Github | LFID |
10+
|----------------|------------------------|-----------|
11+
| Andrii Kliui | [andrii-kl][andrii-kl] | |
12+
| Conor Svensson | [conor10][conor10] | conor |
13+
| George Ţebrean | [gtebrean][gtebrean] | gtebrean |
14+
| Nischal Sharma | [NickSneo][NickSneo] | nicks1106 |
1415

1516
[conor10]: https://github.com/conor10
1617
[gtebrean]: https://github.com/gtebrean
@@ -21,8 +22,95 @@ Maintainers
2122

2223
**Emeritus Maintainers**
2324

24-
| Name | GitHub | Chat |
25-
|------|------------------|------|
26-
|Christian Felde | [cfelde][cfelde] | cfelde |
25+
| Name | Github | LFID |
26+
|-----------------|---------------------|---------|
27+
| Christian Felde | [cfelde][cfelde] | cfelde |
2728

2829
[cfelde]: https://github.com/cfelde
30+
31+
## Becoming a Maintainer
32+
33+
Web3J welcomes community contribution.
34+
Each community member may progress to become a maintainer.
35+
36+
How to become a maintainer:
37+
38+
- Contribute significantly to the code in web3j repositories.
39+
40+
### Maintainers contribution requirement
41+
42+
The requirement to be able to be proposed as a maintainer is:
43+
44+
- 5 significant changes on code have been authored in this repos by the proposed maintainer and accepted (merged PRs).
45+
46+
### Maintainers approval process
47+
48+
The following steps must occur for a contributor to be "upgraded" as a maintainer:
49+
50+
- The proposed maintainer has the sponsorship of at least one other maintainer.
51+
- This sponsoring maintainer will create a proposal PR modifying the list of
52+
maintainers. (see [proposal PR template](#proposal-pr-template).)
53+
- The proposed maintainer accepts the nomination and expresses a willingness
54+
to be a long-term (more than 6 month) committer by adding a comment in the proposal PR.
55+
- The PR will be communicated in all appropriate communication channels
56+
including at least [web3j-contributors channel on Hyperledger Discord](https://discord.gg/hyperledger),
57+
the [mailing list](https://lists.hyperledger.org/g/web3j)
58+
and any maintainer/community call.
59+
- Approval by at least 2 current maintainers within two weeks of the proposal or
60+
an absolute majority (half the total + 1) of current maintainers.
61+
- Maintainers will vote by approving the proposal PR.
62+
- No veto raised by another maintainer within the voting timeframe.
63+
- All vetoes must be accompanied by a public explanation as a comment in the
64+
proposal PR.
65+
- A veto can be retracted, in that case the voting timeframe is reset and all approvals are removed.
66+
- It is bad form to veto, retract, and veto again.
67+
68+
The proposed maintainer becomes a maintainer either:
69+
70+
- when two weeks have passed without veto since the third approval of the proposal PR,
71+
- or an absolute majority of maintainers approved the proposal PR.
72+
73+
In either case, no maintainer raised and stood by a veto.
74+
75+
## Removing Maintainers
76+
77+
Being a maintainer is not a status symbol or a title to be maintained indefinitely.
78+
79+
It will occasionally be necessary and appropriate to move a maintainer to emeritus status.
80+
81+
This can occur in the following situations:
82+
83+
- Resignation of a maintainer.
84+
- Violation of the Code of Conduct warranting removal.
85+
- Inactivity.
86+
- A general measure of inactivity will be no commits or code review comments
87+
for two reporting quarters, although this will not be strictly enforced if
88+
the maintainer expresses a reasonable intent to continue contributing.
89+
- Reasonable exceptions to inactivity will be granted for known long term
90+
leave such as parental leave and medical leave.
91+
- Other unspecified circumstances.
92+
93+
As for adding a maintainer, the record and governance process for moving a
94+
maintainer to emeritus status is recorded using review approval in the PR making that change.
95+
96+
Returning to active status from emeritus status uses the same steps as adding a
97+
new maintainer.
98+
99+
Note that the emeritus maintainer always already has the required significant contributions.
100+
There is no contribution prescription delay.
101+
102+
## Proposal PR template
103+
104+
```markdown
105+
I propose to add [maintainer github handle] as a Web3J project maintainer.
106+
107+
[maintainer github handle] contributed with many high quality commits:
108+
109+
- [list significant achievements]
110+
111+
Here are [their past contributions on Web3J project](https://github.com/hyperledger/web3j/commits?author=[user github handle]).
112+
113+
Voting ends two weeks from today.
114+
115+
For more information on this process see the Becoming a Maintainer section in the MAINTAINERS.md file.
116+
```

0 commit comments

Comments
 (0)