Skip to content

Complete Overhaul of the Statistics Module #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndreiKingsley opened this issue Jan 31, 2025 · 1 comment
Open

Complete Overhaul of the Statistics Module #465

AndreiKingsley opened this issue Jan 31, 2025 · 1 comment
Labels
lets-plot API and implementation for lets-plot statistics An issue/PR related to statisctical

Comments

@AndreiKingsley
Copy link
Collaborator

AndreiKingsley commented Jan 31, 2025

Problem

Currently, the statistics code resides in a raw, unconfigured project within a private repository. Moreover, more than half of the code is a direct copy of an old version of statistics from Lets-Plot (core), without incorporating any of the fixes made in Lets-Plot. Every time we need add a new statistics we must copy-paste Lets-Plot code again. Additionally, the statistics module completely lacks tests.

Furthermore, statistics are published as a separate artifact, which frequently causes integration issues for users.

Tasks

  • Align the codebase with Lets-Plot to avoid duplication and inconsistencies (simplest solution - use LP internal statistics API for implementation).
  • Move the Statistics API to the main repository.
    • Possibly integrate it into kandy-lets-plot, eliminating the need for a separate artifact, as it serves no real purpose.
  • Then, we can add API for remaining statistics and statistical plots (Add remaining statistics and statistical plots #369).

This also will fix #276.

@AndreiKingsley AndreiKingsley added lets-plot API and implementation for lets-plot statistics An issue/PR related to statisctical labels Jan 31, 2025
@devcrocod
Copy link
Collaborator

Statistics should be put on github, maybe under a personal account or in a closed one in the organization
We can discuss this

@devcrocod devcrocod added this to the Kandy release v0.9.0 milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lets-plot API and implementation for lets-plot statistics An issue/PR related to statisctical
Projects
None yet
Development

No branches or pull requests

2 participants