issue #424 byte[] getting converted to literal string of bits rather than a proper string

Author: ryber

unirest-bdd-tests/src/test/java/BehaviorTests/AsBytesTest.java

@@ -28,14 +28,18 @@
 import kong.unirest.Unirest;
 import org.junit.jupiter.api.Test;
 
+import java.nio.charset.StandardCharsets;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
 class AsBytesTest extends BddTest {
     JacksonObjectMapper om = new JacksonObjectMapper();
 
     @Test
     void getGetResultAsBytes() {
         byte[] content = Unirest.get(MockServer.GET)
-                                .asBytes()
-                                .getBody();
+                .asBytes()
+                .getBody();
 
         RequestCapture cap = om.readValue(content, RequestCapture.class);
 
@@ -57,15 +61,35 @@ void getGetResultAsBytesAsync() throws Exception {
     @Test
     void getGetResultAsBytesAsyncCallback() throws Exception {
         Unirest.get(MockServer.GET)
-                .queryString("fruit","apple")
+                .queryString("fruit", "apple")
                 .asBytesAsync(r -> {
                     RequestCapture cap = om.readValue(r.getBody(), RequestCapture.class);
-                    cap.assertParam("fruit","apple");
+                    cap.assertParam("fruit", "apple");
                     asyncSuccess();
                 })
                 .get()
                 .getBody();
 
         assertAsync();
     }
+
+    @Test // https://github.com/Kong/unirest-java/issues/424
+    void mappingErrorsFromAsBytes() {
+        MockServer.setStringResponse("howdy");
+        String r = Unirest.get(MockServer.ERROR_RESPONSE)
+                .asBytes()
+                .mapError(String.class);
+
+        assertEquals("howdy", r);
+    }
+
+    @Test // https://github.com/Kong/unirest-java/issues/424
+    void mappingErrorsFromAsBytesMapped() {
+        MockServer.setJsonAsResponse(new Foo("howdy"));
+        Foo r = Unirest.get(MockServer.ERROR_RESPONSE)
+                .asBytes()
+                .mapError(Foo.class);
+
+        assertEquals("howdy", r.bar);
+    }
 }

unirest/src/main/java/kong/unirest/BaseResponse.java

@@ -25,6 +25,7 @@
 
 package kong.unirest;
 
+import java.nio.charset.StandardCharsets;
 import java.util.Optional;
 import java.util.function.Consumer;
 import java.util.function.Function;
@@ -141,6 +142,9 @@ private String getErrorBody() {
             return null;
         }
         try {
+            if(body instanceof byte[]){
+                return new String((byte[])body, StandardCharsets.UTF_8);
+            }
             return config.getObjectMapper().writeValue(body);
         } catch (Exception e) {
             return String.valueOf(body);