feat: replace deprecated endpoint for pinging Konnect

Author: GGabriele

cmd/ping.go

@@ -53,12 +53,8 @@ func pingKonnect(ctx context.Context) error {
 	if err != nil {
 		return fmt.Errorf("authenticating with Konnect: %w", err)
 	}
-	fullName := res.FullName
-	if res.FullName == "" {
-		fullName = fmt.Sprintf("%s %s", res.FirstName, res.LastName)
-	}
-	fmt.Printf("Successfully Konnected as %s (%s)!\n",
-		fullName, res.Organization)
+
+	fmt.Printf("Successfully Konnected to the %s organization!\n", res.Name)
 	if konnectConfig.Debug {
 		fmt.Printf("Organization ID: %s\n", res.OrganizationID)
 	}

konnect/login_service.go

@@ -11,20 +11,9 @@ import (
 	"strings"
 )
 
-type user struct {
-	FullName string `json:"full_name,omitempty"`
-}
-
-type org struct {
-	ID   string
-	Name string
-}
-
-type UserInfo struct {
-	Profile user
-	ID      string
-	Email   string
-	Org     org
+type OrgUserInfo struct {
+	Name  string `json:"name,omitempty"`
+	OrgID string `json:"id,omitempty"`
 }
 
 type AuthService service
@@ -128,24 +117,23 @@ func (s *AuthService) LoginV2(ctx context.Context, email,
 		)
 	}
 
-	info, err := s.UserInfo(ctx)
+	info, err := s.OrgUserInfo(ctx)
 	if err != nil {
 		return AuthResponse{}, err
 	}
-	authResponse.FullName = info.Profile.FullName
-	authResponse.Organization = info.Org.Name
-	authResponse.OrganizationID = info.Org.ID
+	authResponse.Name = info.Name
+	authResponse.OrganizationID = info.OrgID
 	return authResponse, nil
 }
 
-func (s *AuthService) UserInfo(ctx context.Context) (*UserInfo, error) {
+func (s *AuthService) OrgUserInfo(ctx context.Context) (*OrgUserInfo, error) {
 	method := http.MethodGet
-	req, err := s.client.NewRequest(method, "/konnect-api/api/userinfo/", nil, nil)
+	req, err := s.client.NewRequest(method, "/v2/organizations/me", nil, nil)
 	if err != nil {
 		return nil, err
 	}
 
-	info := &UserInfo{}
+	info := &OrgUserInfo{}
 	_, err = s.client.Do(ctx, req, info)
 	if err != nil {
 		return nil, err

konnect/types.go

@@ -137,10 +137,12 @@ type ControlPlaneType struct {
 
 // AuthResponse is authentication response wrapper for login.
 type AuthResponse struct {
-	Organization   string `json:"org_name"`
-	FirstName      string `json:"first_name"`
-	LastName       string `json:"last_name"`
+	Name           string `json:"name"`
 	OrganizationID string `json:"org_id"`
 
-	FullName string `json:"full_name"`
+	// deprecated fields
+	Organization string `json:"org_name"`
+	FirstName    string `json:"first_name"`
+	LastName     string `json:"last_name"`
+	FullName     string `json:"full_name"`
 }

tests/integration/ping_test.go

@@ -0,0 +1,16 @@
+//go:build integration
+
+package integration
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func Test_KonnectPing(t *testing.T) {
+	t.Run("konnect ping", func(t *testing.T) {
+		runWhen(t, "konnect", "")
+		require.NoError(t, ping())
+	})
+}

tests/integration/test_utils.go

@@ -261,3 +261,13 @@ func dump(opts ...string) (string, error) {
 
 	return string(out), cmdErr
 }
+
+func ping(opts ...string) error {
+	deckCmd := cmd.NewRootCmd()
+	args := []string{"ping"}
+	if len(opts) > 0 {
+		args = append(args, opts...)
+	}
+	deckCmd.SetArgs(args)
+	return deckCmd.ExecuteContext(context.Background())
+}