-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: speed-controlled fans #24483
feat: speed-controlled fans #24483
Conversation
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Not stale, depends on another PR. |
@lorenz could you take a look at the failing CI? |
78c8f50
to
4e8ff68
Compare
Most things are fixed, now it wants me to add test coverage for an assert statement, I'm not sure how I would even test that considering that an assert basically aborts the NodeJS runtime. |
You can find plenty of examples in current tests, usually in that format: expect(() => {
// TODO
}).toThrow('The error message'); |
This implements the discovery side for speed-controlled fans. Here we no longer need to emulate speed changes by changing modes and there is a readily-usable onOff cluster for state. Fans now need to be either mode- or speed-controlled, otherwise an assert is hit. No such fans currently exist in the Z2M codebase and they cannot be reasonably controlled anyways.
Fixed it by removing the branch and using the assertion value. |
Thanks! |
This implements the discovery side for speed-controlled fans. Here we no
longer need to emulate speed changes by changing modes and there is a
readily-usable onOff cluster for state. Fans now need to be either mode-
or speed-controlled, otherwise an assert is hit. No such fans currently
exist in the Z2M codebase and they cannot be reasonably controlled
anyways.
Co-dependent with Koenkk/zigbee-herdsman-converters#8188