Allow app running under subpath #24244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-kotikov
force-pushed
the
app_base_url
branch
3 times, most recently
from
a53d3cc to
aee23bb
Compare
|
Just realized there's a #19911 which does pretty much the same, although I noticed there's no changes for the websocket url so I'm not quite sure how's that supposed to work. |
|
Could you also update the settings schema? |
vladimir-kotikov
force-pushed
the
app_base_url
branch
from
a3ad019 to
fdaca4a
Compare
|
Done! |
|
Thanks! |
This was referenced Nov 7, 2024
[Bug]: Regression on 1.41.0 when running behind nginx reverse proxy
nurikk/zigbee2mqtt-frontend#2223
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently impossible as the WS server is only accepting requests on
/apiurl, plus serve-static is pretty straightforward about serving files and can not be configured with a base directory. This change allows to set a base subdirectory for the Z2M app including websocket listener and rewrites request urls when serving static files so that they are resolved correctly.