Skip to content

feat: Support automatically generating device definitions #20358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 25, 2023

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Dec 23, 2023

2023-12-23 09 34 49

TODO

  • Extend device definition generator a bit more to at least support lights and electrical measurements
  • Update How to support new devices page
  • Enable the device definition generator and test
  • Check support new devices issue template

Related PRs

CC: @ffenix113, @kirovilya, @sjorge, @nurikk, @mundschenk-at

@sjorge
Copy link
Contributor

sjorge commented Dec 24, 2023

  • Should we show the button for supported devices?
  • Maybe add a save option like we do with extensions (although I don't think we have an api endpoint to reload an external definition, would that even make sense?)

@Koenkk
Copy link
Owner Author

Koenkk commented Dec 24, 2023

Should we show the button for supported devices?

Yes, in case e.g. an already supported device does not have all features in the definition, the generated definition can be used instead

Maybe add a save option like we do with extensions (although I don't think we have an api endpoint to reload an external definition, would that even make sense?)

Ideally you should be able to edit the external definition directly from the frontend for quick prototyping.

@sjorge
Copy link
Contributor

sjorge commented Dec 24, 2023

Ideally you should be able to edit the external definition directly from the frontend for quick prototyping.

If the external one takes priority over one from zhc, this would be great when adding new features to a device indeed!

@Koenkk
Copy link
Owner Author

Koenkk commented Dec 25, 2023

If the external one takes priority over one from zhc, this would be great when adding new features to a device indeed!

That's already the case (ext converter always takes priority over ZHC definition)

@Koenkk Koenkk marked this pull request as ready for review December 25, 2023 11:44
@Koenkk Koenkk merged commit 56f5762 into dev Dec 25, 2023
@Koenkk Koenkk deleted the feat/auto_definition_generation branch December 25, 2023 11:46
@Koenkk
Copy link
Owner Author

Koenkk commented Dec 25, 2023

Just in time for Christmas, merry Christmas all! 🎄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants