fix: Fix unable to configure again after configure fails (#19908)

slugzero · web-flow · commit a904e7a396e3 · 2023-11-30T23:02:16.000+01:00
* Remove device from "configuring" after error

* use finally for cleanup
diff --git a/lib/extension/configure.ts b/lib/extension/configure.ts
@@ -129,8 +129,8 @@ export default class Configure extends Extension {
             if (throwError) {
                 throw error;
             }
+        } finally {
+            this.configuring.delete(device.ieeeAddr);
         }
-
-        this.configuring.delete(device.ieeeAddr);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -129,8 +129,8 @@ export default class Configure extends Extension {`
`129`	`129`	`if (throwError) {`
`130`	`130`	`throw error;`
`131`	`131`	`}`
	`132`	`+ } finally {`
	`133`	`+ this.configuring.delete(device.ieeeAddr);`
`132`	`134`	`}`
`133`		`-`
`134`		`- this.configuring.delete(device.ieeeAddr);`
`135`	`135`	`}`
`136`	`136`	`}`