Skip to content

Commit 06ba62b

Browse files
authored
fix(ignore): update zigbee-herdsman-converters to 23.6.0 (#26691)
1 parent ea5e0d4 commit 06ba62b

File tree

5 files changed

+19
-16
lines changed

5 files changed

+19
-16
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"winston-transport": "^4.9.0",
6464
"ws": "^8.18.1",
6565
"zigbee-herdsman": "3.3.2",
66-
"zigbee-herdsman-converters": "23.4.0",
66+
"zigbee-herdsman-converters": "23.6.0",
6767
"zigbee2mqtt-frontend": "0.9.4"
6868
},
6969
"devDependencies": {

pnpm-lock.yaml

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/extensions/homeassistant.test.ts

+4-7
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import * as data from '../mocks/data';
22
import {mockLogger} from '../mocks/logger';
33
import {events as mockMQTTEvents, mockMQTTPublishAsync, mockMQTTSubscribeAsync, mockMQTTUnsubscribeAsync} from '../mocks/mqtt';
44
import * as mockSleep from '../mocks/sleep';
5-
import {flushPromises} from '../mocks/utils';
5+
import {flushPromises, getZhcBaseDefinitions} from '../mocks/utils';
66
import {devices, groups, events as mockZHEvents} from '../mocks/zigbeeHerdsman';
77

88
import assert from 'node:assert';
@@ -83,11 +83,8 @@ describe('Extension: HomeAssistant', () => {
8383
it('Should not have duplicate type/object_ids in a mapping', async () => {
8484
const duplicated: string[] = [];
8585

86-
(await import('zigbee-herdsman-converters/devices/index')).default.forEach((baseDefinition) => {
87-
const d = zhc.prepareDefinition(
88-
// @ts-expect-error inferred type is wrong
89-
baseDefinition,
90-
);
86+
for (const baseDefinition of await getZhcBaseDefinitions()) {
87+
const d = zhc.prepareDefinition(baseDefinition);
9188
const exposes = typeof d.exposes == 'function' ? d.exposes(undefined, undefined) : d.exposes;
9289
const device = {
9390
definition: d,
@@ -112,7 +109,7 @@ describe('Extension: HomeAssistant', () => {
112109
cfgTypeObjectIds.push(id);
113110
}
114111
});
115-
});
112+
}
116113

117114
expect(duplicated).toHaveLength(0);
118115
});

test/extensions/onEvent.test.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as data from '../mocks/data';
22
import {mockLogger} from '../mocks/logger';
33
import {mockMQTTPublishAsync} from '../mocks/mqtt';
4-
import {flushPromises} from '../mocks/utils';
4+
import {flushPromises, getZhcBaseDefinitions} from '../mocks/utils';
55
import {devices, events as mockZHEvents} from '../mocks/zigbeeHerdsman';
66

77
import {MockInstance} from 'vitest';
@@ -19,8 +19,8 @@ describe('Extension: OnEvent', () => {
1919
let mockLivoloOnEvent: MockInstance;
2020

2121
beforeAll(async () => {
22-
const mappedLivolo = (await zhc.findByDevice(devices.LIVOLO))!;
23-
mockLivoloOnEvent = vi.spyOn(mappedLivolo, 'onEvent');
22+
const livoloDefinition = (await getZhcBaseDefinitions()).find((d) => d.zigbeeModel?.includes(devices.LIVOLO.modelID!))!;
23+
mockLivoloOnEvent = vi.spyOn(livoloDefinition, 'onEvent');
2424
});
2525

2626
beforeEach(async () => {

test/mocks/utils.ts

+6
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import type {DefinitionWithExtend} from 'zigbee-herdsman-converters';
2+
13
export type EventHandler = (...args: unknown[]) => unknown;
24

35
export async function flushPromises(): Promise<void> {
@@ -12,3 +14,7 @@ export function defuseRejection<T>(promise: Promise<T>): Promise<T> {
1214

1315
return promise;
1416
}
17+
18+
export async function getZhcBaseDefinitions(): Promise<DefinitionWithExtend[]> {
19+
return (await import('zigbee-herdsman-converters/devices/index')).default;
20+
}

0 commit comments

Comments
 (0)