feat: Generate definition for unsupported Green Power devices #9020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerivec
force-pushed
the
generate-for-gp
branch
from
3c13fe7 to
86d19b2
Compare
Nerivec
commented
Mar 18, 2025
Koenkk
reviewed
Mar 20, 2025
I think that's fine |
Nerivec
force-pushed
the
generate-for-gp
branch
from
e37b472 to
14bdf67
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Koenkk not sure about the best way to display the payload? Frontend shows the array as a plain string
[1]as it is right now.This should also allow partially supporting the Moes ZEU2S that doesn't appear to have a fixed source ID... (otherwise used to identify an actual converter for GP devices). ref: Koenkk/zigbee2mqtt#19405
Tested with a PTM216Z from enocean by removing its actual converter.