Re-add on_time and off_wait_time to the light_onoff_brightness converter #8942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8642 it was stated that the
on_time
andoff_wait_time
keys were unused in thelight_onoff_brightness
converter, and they were removed shortly thereafter in 099ea3a.Recently, after upgrading Z2M, I noticed that some of my light controller automations (which rely on the On With Timed Off command) stopped working. After checking the changelog, I quickly realized what the cause was.
In this PR, I'd like to completely revert these changes.
Some additional context:
In #8175, I added the
off_wait_time
to this converter, and in the description of that PR, I detailed how thelight_onoff_brightness
converter can delegate to theon_off
converter, which actually uses theon_time
andoff_wait_time
keys.I was able to successfully use the
on_time
property for these lights (not a complete list):