Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add on_time and off_wait_time to the light_onoff_brightness converter #8942

Conversation

marazmarci
Copy link
Contributor

@marazmarci marazmarci commented Mar 6, 2025

In #8642 it was stated that the on_time and off_wait_time keys were unused in the light_onoff_brightness converter, and they were removed shortly thereafter in 099ea3a.

Recently, after upgrading Z2M, I noticed that some of my light controller automations (which rely on the On With Timed Off command) stopped working. After checking the changelog, I quickly realized what the cause was.

In this PR, I'd like to completely revert these changes.

Some additional context:

In #8175, I added the off_wait_time to this converter, and in the description of that PR, I detailed how the light_onoff_brightness converter can delegate to the on_off converter, which actually uses the on_time and off_wait_time keys.

I was able to successfully use the on_time property for these lights (not a complete list):

@LaurentChardin
Copy link
Contributor

As replied here #8642 (comment)

@Koenkk we should revert it and i will look into another way to address the issue of devices that do not support some of the capabilities.

@Koenkk Koenkk merged commit d029330 into Koenkk:master Mar 8, 2025
5 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Mar 8, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants