Skip to content

fix: Add manuSpecificPhilips3 to every Philips light #8872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Feb 22, 2025

result.toZigbee.push(philipsTz.hue_power_on_behavior, philipsTz.hue_power_on_error);
return result;
}
const customCluster = m.deviceAddCustomCluster("manuSpecificPhilips3", {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrivers lot's of refactoring here, but this is basically the thing that is needed. Let me know if this is OK and I will merge it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! That's amazing @Koenkk :D

Let me just give this a look!

@chrivers
Copy link
Contributor

As far as I can tell (and I'll admit, I don't 100% fully understand all the changes yet), this looks great 👍

Thank you so much for taking the time to help out with this! Really, really appricated :)

Feel free to merge, I'll be happy to test right away!

@Koenkk Koenkk merged commit bc2abbc into master Feb 23, 2025
7 checks passed
@Koenkk Koenkk deleted the fix/manuSpecificPhilips3 branch February 23, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants