fix: Migrate from eslint/prettier to Biome #8859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerivec
reviewed
Feb 21, 2025
Nerivec
reviewed
Feb 21, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if (externalDefinitionsLookup.has(lookupModel)) { | ||
| return externalDefinitionsLookup.get(lookupModel); | ||
| } | ||
|
|
||
| return externalDefinitionsLookup.get(lookupModel.replace(/\0(.|\n)*$/g, '').trim()); | ||
| return externalDefinitionsLookup.get(lookupModel.replace(/\0(.|\n)*$/g, "").trim()); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| @@ -218,7 +218,7 @@ | |||
| return await getDefinitions(indexes); | |||
| } | |||
|
|
|||
| indexes = MODELS_INDEX[lookupModel.replace(/\0(.|\n)*$/g, '').trim()]; | |||
| indexes = MODELS_INDEX[lookupModel.replace(/\0(.|\n)*$/g, "").trim()]; | |||
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
|
Since you are the file owner, could you check this @martyn-vesternet? Caused by: |
|
Since you are the file owner, could you check this @candeodevelopment / @dhc25? Caused by: |
This was referenced Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC: @Nerivec
CI lint/format step went from 27 to 1 second! 😮