Add SPM01V2 data report duration configuration #8843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Koenkk Not sure why GitHub is showing an error message for this PR Can you help me figure this out when you have a moment? Thanks. |
Koenkk
reviewed
Feb 20, 2025
| @@ -9672,6 +9672,13 @@ export const definitions: DefinitionWithExtend[] = [ | |||
| e.produced_energy().withDescription('Total reverse active energy'), | |||
| e.power_factor().withUnit('%'), | |||
| e.ac_frequency(), | |||
| e | |||
| .numeric('data_report_duration', ea.SET) | |||
There was a problem hiding this comment.
Suggested change
| .numeric('data_report_duration', ea.SET) | |
| .numeric('data_report_interval', ea.SET) |
Would this name make more sense?
There was a problem hiding this comment.
I am ok either way, the reason for the name I used is that in Tuya app that is how it is called when updating firmware - see screenshot here.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 3.1.3 firmware for SPM01V2 it is possible to "Data report duration set (Threshold value range 5~3600 seconds)". See here.
This change adds support for that into zigbee2mqtt.
This addresses this issue.