Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ikea.ts #8801

Merged
merged 5 commits into from
Feb 14, 2025
Merged

Update ikea.ts #8801

merged 5 commits into from
Feb 14, 2025

Conversation

chris-1243
Copy link
Contributor

Added CH version

Added CH version
@chris-1243
Copy link
Contributor Author

According to https://zigbee.blakadder.com/Ikea_E1603.html

There many numbers of this device. Should we add them?

@Koenkk
Copy link
Owner

Koenkk commented Feb 12, 2025

Let's do that, could you also make a PR to update the picture? (keep the old one to prevent the tests from failing)

@chris-1243
Copy link
Contributor Author

I am just stuck on how to proceed. The E1902 shares the same modelID as the E1603 and the E1703 as well.

Should we just add the model like:

model: 'E1603/E1702/E1703/E1704.../E1902'

E1902 entry in database.db

{"id":14,"type":"Router","ieeeAddr":"0x804b50fffe69529e","nwkAddr":58945,"manufId":4476,"manufName":"IKEA of Sweden","powerSource":"Mains (single phase)","modelId":"TRADFRI control outlet","epList":[1,242],"endpoints":{"1":{"profId":260,"epId":1,"devId":266,"inClusterList":[0,3,4,5,6,8,4096,64636],"outClusterList":[25,32,4096],"clusters":{"genBasic":{"attributes":{"modelId":"TRADFRI control outlet","manufacturerName":"IKEA of Sweden","powerSource":1,"zclVersion":3,"appVersion":33,"stackVersion":98,"hwVersion":1,"dateCode":"20211118","swBuildId":"2.3.089"}},"genOnOff":{"attributes":{"onOff":0,"startUpOnOff":255}}},"binds":[{"cluster":6,"type":"endpoint","deviceIeeeAddress":"0x00124b0026d15e0e","endpointID":1}],"configuredReportings":[{"cluster":6,"attrId":0,"minRepIntval":0,"maxRepIntval":65000,"repChange":1}],"meta":{}},"242":{"profId":41440,"epId":242,"devId":97,"inClusterList":[],"outClusterList":[33],"clusters":{},"binds":[],"configuredReportings":[],"meta":{}}},"appVersion":33,"stackVersion":98,"hwVersion":1,"dateCode":"20211118","swBuildId":"2.3.089","zclVersion":3,"interviewCompleted":true,"meta":{"configured":332242049},"lastSeen":1739356385365}

Added multiple `whitelabel` for some IKEA plugs
@chris-1243
Copy link
Contributor Author

I have not yet added pictures. I am waiting first to hear from you if the syntax looks ok... (Sorry for the multiple commits. I am still stubborn enough not to use your tools...)

vendor: 'IKEA',
description: 'TRETAKT smart plug',
whiteLabel: [
{model: 'E2204', vendor: 'IKEA', description: 'E2204 (EU)', fingerprint: [{modelID: 'TRETAKT Smart plug'}]},
{model: 'E2214', vendor: 'IKEA', description: 'E2214 (CH)', fingerprint: [{modelID: 'TRETAKT Smart plug'}]},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! You can drop the fingerprints (fingerprint) since they are all the same

Copy link
Contributor Author

@chris-1243 chris-1243 Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I may do the same for the E1603. Lines 570 and more

Remove fingerprint
@Koenkk Koenkk merged commit 9a33433 into Koenkk:master Feb 14, 2025
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Feb 14, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants