-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ikea.ts #8801
Update ikea.ts #8801
Conversation
Added CH version
According to https://zigbee.blakadder.com/Ikea_E1603.html There many numbers of this device. Should we add them? |
Let's do that, could you also make a PR to update the picture? (keep the old one to prevent the tests from failing) |
I am just stuck on how to proceed. The E1902 shares the same modelID as the E1603 and the E1703 as well. Should we just add the model like: model: 'E1603/E1702/E1703/E1704.../E1902' E1902 entry in database.db
|
Added multiple `whitelabel` for some IKEA plugs
I have not yet added pictures. I am waiting first to hear from you if the syntax looks ok... (Sorry for the multiple commits. I am still stubborn enough not to use your tools...) |
src/devices/ikea.ts
Outdated
vendor: 'IKEA', | ||
description: 'TRETAKT smart plug', | ||
whiteLabel: [ | ||
{model: 'E2204', vendor: 'IKEA', description: 'E2204 (EU)', fingerprint: [{modelID: 'TRETAKT Smart plug'}]}, | ||
{model: 'E2214', vendor: 'IKEA', description: 'E2214 (CH)', fingerprint: [{modelID: 'TRETAKT Smart plug'}]}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! You can drop the fingerprints (fingerprint
) since they are all the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I may do the same for the E1603. Lines 570 and more
Remove fingerprint
Thanks! |
Added CH version