Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: System mode in Namron thermostat #8753

Merged
merged 31 commits into from
Feb 9, 2025

Conversation

bskjon
Copy link
Contributor

@bskjon bskjon commented Feb 6, 2025

I'm currently seeing some incorrect display of the values:
image
How do i solve this?

This is just one of the places

@bskjon bskjon changed the title fix: System mode in fix: System mode in Namron thermostat Feb 6, 2025
@Koenkk
Copy link
Owner

Koenkk commented Feb 6, 2025

I'm currently seeing some incorrect display of the values:

What is incorrect here?

@bskjon
Copy link
Contributor Author

bskjon commented Feb 6, 2025

I'm currently seeing some incorrect display of the values:

What is incorrect here?

The underscores doesn't go away like the rest
Will it be fine if i just remove them?

@Koenkk
Copy link
Owner

Koenkk commented Feb 7, 2025

Will it be fine if i just remove them?

No, if it should be fixed (I'm not sure) it should be fixed in the frontend.

@bskjon
Copy link
Contributor Author

bskjon commented Feb 7, 2025

Will it be fine if i just remove them?

No, if it should be fixed (I'm not sure) it should be fixed in the frontend.

image
It will also be wrong in homeassistant 🤔

@bskjon
Copy link
Contributor Author

bskjon commented Feb 7, 2025

So i should not edit the file to be more like

        deviceFault: (args?: Partial<modernExtend.EnumLookupArgs>) =>
            modernExtend.enumLookup({
                name: 'fault',
                cluster: 'hvacThermostat',
                attribute: {ID: 0x8006, type: Zcl.DataType.ENUM8},
                description: 'Device fault',
                lookup: {
                    no_fault: 0,
                    over_current_error: 1,
                    over_heat_error: 2,
                    'built-in_sensor_error': 3,
                    air_sensor_error: 4,
                    floor_sensor_error: 5,
                },
                access: 'STATE_GET',
                ...args,
            }),

to:

       deviceFault: (args?: Partial<modernExtend.EnumLookupArgs>) =>
            modernExtend.enumLookup({
                name: 'fault',
                cluster: 'hvacThermostat',
                attribute: {ID: 0x8006, type: Zcl.DataType.ENUM8},
                description: 'Device fault',
                lookup: {
                    "No Fault": 0,
                    "Over current error": 1,
                    "Over heat error": 2,
                    "Built-in sensor error": 3,
                    "Air sensor error": 4,
                    "Floor sensor error": 5,
                },
                access: 'STATE_GET',
                ...args,
            }),

@Koenkk
Copy link
Owner

Koenkk commented Feb 8, 2025

The convention is to have _ instead of , so then I would propose to leave it as is.

@Koenkk Koenkk merged commit f44625f into Koenkk:master Feb 9, 2025
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Feb 9, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants