Added type for LightArgs.levelConfig #8724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In modernExtend the interface LightArgs.levelConfig.disableFeatures uses a generic string[] type. This argument is tightly bound to 6 options but there is no autocomplete for it.
I exported a new type called LevelConfigFeatures form types.
Applied the type to:
I thought the best option would be to apply the type directly to withLevelConfig and work out from there instead of just applying it the interface. I debated weather to export directly form extend.ts but decided types.ts was the best option. If you want any changes let me know.