Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional improvements for Inovelli devices #8700

Merged
merged 4 commits into from
Feb 2, 2025

Conversation

rohankapoorcom
Copy link
Contributor

In preparation for the new VMZ32-SN, I spent some time fixing some issues with the existing converter as well as moving around some attributes to make the new integration simpler.

  1. Made a bunch of the Inovelli attribute fz/tz converters cluster aware (since the new device will use multiple clusters with attributes that need to be exposed).
  2. Updated the Inovelli attribute fz converter to handle reading attributes from multiple endpoints (needed for the VZM36 which previously failed). This fixes Inovelli VZM36 reads attributes into incorrect property names zigbee2mqtt#22459.
  3. Moved all of the dimmable light attributes to a separate object to allow for reuse with VZM32-SN.
  4. Renamed leadingTrailingEdge_1 to dimmingMode and made it visible (but readonly on all dimmers) while keeping it read/write on VZM36
  5. Added a call at the end of configure for each device to read the values of all of the attributes for that device so that they are not blank requiring the user to manually hit refresh (or call the mqtt get api) for each one. Fixes: https://community.inovelli.com/t/null-states-in-z2m/18543

CC: @InovelliUSA

@Koenkk
Copy link
Owner

Koenkk commented Jan 30, 2025

@InovelliUSA could you review this?

@InovelliUSA
Copy link
Contributor

@InovelliUSA could you review this?

Tested it and everything seems to be working for me.

@rohankapoorcom
Copy link
Contributor Author

Since this wasn't merged yet, I fixed a couple of additional bugs that Eric (@InovelliUSA) reported to me directly with this converter where the breeze mode and fan state where not being read correctly for the VZM36.

@Koenkk Koenkk merged commit 959b96e into Koenkk:master Feb 2, 2025
2 checks passed
@Koenkk
Copy link
Owner

Koenkk commented Feb 2, 2025

Thanks!

@rohankapoorcom rohankapoorcom deleted the more-inovelli-improvements branch February 2, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inovelli VZM36 reads attributes into incorrect property names
3 participants