Improvement to W599001 Smoke Alarm

[mattbyte]

Adding support to expose heat alarm and hush mode bringing support closer to parity with that of the manufacturer hub and app. The heat alarm is for detecting fires and will sound the device siren, therefore, it is important that it be exposed for use. I used fzLocal as the hush bit is appears to be manufacturer specific (not specified in ZCL).

[Koenkk]

could you extend and use:

zigbee-herdsman-converters/src/lib/modernExtend.ts

Line 1487 in 2d229ff

export function iasZoneAlarm(args: IasArgs): ModernExtend {

instead?

Example usage:

zigbee-herdsman-converters/src/devices/adeo.ts

Line 439 in 2d229ff

iasZoneAlarm({zoneType: 'occupancy', zoneAttributes: ['alarm_1', 'tamper', 'battery_low']}),

[mattbyte]

As in make a local version of the iasZoneAlarm modern extend that can do the hush mode bit decode or add the functionality to modernExtend.ts?

[Koenkk]

Add the functionality to modernExtend.ts

[mattbyte]

No worries, done! Have tested and it correctly configures the reporting and binding as before. Only slight negative is no ability to tell the user that the second alarm is heat while the first is smoke.

One option would be to add a new argument maybe called secondaryZoneType?

zigbee-herdsman-converters/src/lib/modernExtend.ts

Lines 1480 to 1486 in 2d229ff

	export interface IasArgs {
	zoneType: iasZoneType;
	zoneAttributes: iasZoneAttribute[];
	alarmTimeout?: boolean;
	zoneStatusReporting?: boolean;
	description?: string;
	}

I think it is also acceptable as is, at least both alarms are exposed.

[Koenkk]

I reliase now that this option is device specific, therefore it cannot be put directly here. I think we should allow passing custom attributes to iasZoneAlarm instead.

[mattbyte]

Have had a go at implementing passing of custom (manufacturer) zone attributes to iasZoneAlarm. Not yet fully tested as I wanted to confirm I'm on the right track first. Based on the binary modern extend of course.

[Koenkk]

Well done, thanks!