Add two private attributes for SR-ZG9040A/ZG9041A-D. #8210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maginawin
commented
Oct 28, 2024
maginawin
commented
- External Switch Type
- Minimum PWM
1. External Switch Type 2. Minimum PWM
Koenkk
reviewed
Oct 28, 2024
src/devices/sunricher.ts
Outdated
| ]; | ||
|
|
||
| const onEvent: OnEvent = async (type, data, device) => { | ||
| await readAttributeIfOnline(type, data, device, attribute); |
There was a problem hiding this comment.
I think these only need to be read one time after the device has joined? If yes, put them in a configure.
Koenkk
reviewed
Oct 28, 2024
src/devices/sunricher.ts
Outdated
|
|
||
| const toZigbee: Tz.Converter[] = [ | ||
| { | ||
| key: ['minimumPWM'], |
There was a problem hiding this comment.
Suggested change
| key: ['minimumPWM'], | |
| key: ['minimum_pwm'], |
Koenkk
reviewed
Oct 28, 2024
src/devices/sunricher.ts
Outdated
|
|
||
| const exposes: Expose[] = [ | ||
| e | ||
| .numeric('minimumPWM', ea.ALL) |
There was a problem hiding this comment.
Suggested change
| .numeric('minimumPWM', ea.ALL) | |
| .numeric('minimum_pwm', ea.ALL) |
Koenkk
reviewed
Oct 28, 2024
src/devices/sunricher.ts
Outdated
| const attribute = 0x8803; | ||
| const dataType = 0x20; | ||
| const valueMap: {[key: number]: string} = { | ||
| 0: 'Push button', |
There was a problem hiding this comment.
Please make all snake_case, also valueLookup below
Koenkk
reviewed
Oct 28, 2024
src/devices/sunricher.ts
Outdated
| } satisfies Tz.Converter, | ||
| ]; | ||
|
|
||
| const exposes: Expose[] = [e.enum('externalSwitchType', ea.ALL, ['Push button', 'Normal on/off', 'Three way']).withLabel('External Switch Type')]; |
There was a problem hiding this comment.
Suggested change
| const exposes: Expose[] = [e.enum('externalSwitchType', ea.ALL, ['Push button', 'Normal on/off', 'Three way']).withLabel('External Switch Type')]; | |
| const exposes: Expose[] = [e.enum('external_switch_type', ea.ALL, ['push_button', 'normal_on_off', 'three_way']).withLabel('External switch type')]; |
1. External Switch Type 2. Minimum PWM
|
Hi @Koenkk , thank you for your detailed suggestions, I've modified them. |
|
Thanks! |
|
@maginawin Hi, this change seems aimed at SR-ZG9040A/ZG9041A-D but it also affects https://www.zigbee2mqtt.io/devices/ZG9101SAC-HP-Switch.html. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.