Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/philips.ts and lib/modernExtend.js are only partially multi-endpoint aware #8027

Closed
mundschenk-at opened this issue Sep 25, 2024 · 0 comments · Fixed by #8031
Closed

Comments

@mundschenk-at
Copy link
Contributor

As a follow-up to Koenkk/zigbee2mqtt#23652, I think I have discovered why the "naive" converter implementation only partially works. From line 60 onwards, philipsLight is not multi-endpoint aware.

The power_on_behavior expose handling in https://github.com/Koenkk/zigbee-herdsman-converters/blob/master/src/lib/modernExtend.ts#L1008 also does not take endpoints into account. (There might other functions affected.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant