fix(refactor): Migrate GTZ10 to generic device_mode mapping value converter

Author: andreypuhovsky

src/devices/tuya.ts

@@ -5601,9 +5601,9 @@ const definitions: DefinitionWithExtend[] = [
                     'system_mode',
                     tuya.valueConverter.thermostatSystemModeAndPresetMap({
                         toMap: {
-                        auto: new tuya.Enum(0), // auto
-                        heat: new tuya.Enum(1), // manual
-                        off: new tuya.Enum(2), // off
+                            auto: new tuya.Enum(0), // auto
+                            heat: new tuya.Enum(1), // manual
+                            off: new tuya.Enum(2), // off
                         },
                     }),
                 ],
@@ -5612,10 +5612,10 @@ const definitions: DefinitionWithExtend[] = [
                     'preset',
                     tuya.valueConverter.thermostatSystemModeAndPresetMap({
                         toMap: {
-                        none: new tuya.Enum(1), // manual
-                        eco: new tuya.Enum(3), // eco
-                        comfort: new tuya.Enum(4), // comfort
-                        boost: new tuya.Enum(5), // boost
+                            none: new tuya.Enum(1), // manual
+                            eco: new tuya.Enum(3), // eco
+                            comfort: new tuya.Enum(4), // comfort
+                            boost: new tuya.Enum(5), // boost
                         },
                     }),
                 ],
@@ -13389,9 +13389,45 @@ const definitions: DefinitionWithExtend[] = [
         ],
         meta: {
             tuyaDatapoints: [
-                [2, null, tuya.valueConverter.thermostatGtz10SystemModeAndPreset(null)],
-                [2, 'preset', tuya.valueConverter.thermostatGtz10SystemModeAndPreset('preset')],
-                [2, 'system_mode', tuya.valueConverter.thermostatGtz10SystemModeAndPreset('system_mode')],
+                [
+                    2,
+                    null,
+                    tuya.valueConverter.thermostatSystemModeAndPresetMap({
+                        fromMap: {
+                            0: {device_mode: 'manual', system_mode: 'heat', preset: 'manual'},
+                            1: {device_mode: 'auto', system_mode: 'auto', preset: 'auto'},
+                            2: {device_mode: 'holiday', system_mode: 'heat', preset: 'holiday'},
+                            3: {device_mode: 'comfort', system_mode: 'heat', preset: 'comfort'},
+                            4: {device_mode: 'eco', system_mode: 'heat', preset: 'eco'},
+                            5: {device_mode: 'off', system_mode: 'off', preset: 'off'},
+                        },
+                    }),
+                ],
+                [
+                    2,
+                    'preset',
+                    tuya.valueConverter.thermostatSystemModeAndPresetMap({
+                        toMap: {
+                            manual: new tuya.Enum(0),
+                            auto: new tuya.Enum(1),
+                            holiday: new tuya.Enum(2),
+                            comfort: new tuya.Enum(3),
+                            eco: new tuya.Enum(4),
+                            off: new tuya.Enum(5),
+                        },
+                    }),
+                ],
+                [
+                    2,
+                    'system_mode',
+                    tuya.valueConverter.thermostatSystemModeAndPresetMap({
+                        toMap: {
+                            heat: new tuya.Enum(0),
+                            auto: new tuya.Enum(1),
+                            off: new tuya.Enum(5),
+                        },
+                    }),
+                ],
                 [4, 'current_heating_setpoint', tuya.valueConverter.divideBy10],
                 [5, 'local_temperature', tuya.valueConverter.divideBy10],
                 [6, 'battery', tuya.valueConverter.raw],

src/lib/tuya.ts

@@ -1173,44 +1173,6 @@ export const valueConverter = {
             },
         };
     },
-    thermostatGtz10SystemModeAndPreset: (toKey: string) => {
-        return {
-            from: (v: string) => {
-                utils.assertNumber(v, 'system_mode');
-                const presetLookup = {
-                    0: 'manual',
-                    1: 'auto',
-                    2: 'holiday',
-                    3: 'comfort',
-                    4: 'eco',
-                    5: 'off',
-                };
-                const systemModeLookup = {
-                    0: 'heat',
-                    1: 'auto',
-                    5: 'off',
-                };
-                return {preset: presetLookup[v], system_mode: systemModeLookup[v]};
-            },
-            to: (v: string) => {
-                const presetLookup = {
-                    manual: new Enum(0),
-                    auto: new Enum(1),
-                    holiday: new Enum(2),
-                    comfort: new Enum(3),
-                    eco: new Enum(4),
-                    off: new Enum(5),
-                };
-                const systemModeLookup = {
-                    heat: new Enum(0),
-                    auto: new Enum(1),
-                    off: new Enum(5),
-                };
-                const lookup = toKey === 'preset' ? presetLookup : systemModeLookup;
-                return utils.getFromLookup(v, lookup);
-            },
-        };
-    },
     ZWT198_schedule: {
         from: (value: number[], meta: Fz.Meta, options: KeyValue) => {
             const programmingMode = [];