spirv-val: Print Storage Class in error message

[spencer-lunarg]

I basically wanted to add StorageClassToString() found in spirv.hpp11 to some error messages the clear up what the actually error is.

Before I go around adding it (or maybe can update it as a drop in replacement) wanted to know if there is some util somewhere

[alan-baker]

I'm not aware of anything, most places in the validator just write out the storage class when it is very few values or ignore printing it (maybe hoping the disassembly shows it).

[spencer-lunarg]

The main issue is the new #5958 check. It really doesn't explain what is wrong and have had a few people ping me (since they hit it when updating VVL) go "so wait, what is the issue, what broke?" and was hoping to have that error spell out what is going on... which led me to realize there was no StorageClass to string to print an error message

[alan-baker]

Is that the right issue? Those checks don't seem like they need a storage class. Did you mean #6012? I could see attaching the storage class it was instantiated for that.

[spencer-lunarg]

sorry yes, #6012 - yes, it is not obvious to the user from the error the issue is ArrayStride is required for Uniform or StorageBuffer but then required to not be there for Private.

Also I have a MR up to try and add a VUID to help direct people to the spec text as well