Skip to content

Commit faf7bd2

Browse files
[fei6062.3.releasing] Catch the RELEASING commit issueprotections (#2417)
## Summary: For some reason, merging Version Packages didn't do a squash merge and that meant we got the change Issue: FEI-6062 ## Test plan: Author: somewhatabstract Reviewers: somewhatabstract, jandrade Required Reviewers: Approved By: jandrade Checks: ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ⏭️ Chromatic - Skip on Release PR (changesets), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ⏭️ dependabot, ✅ gerald Pull Request URL: #2417
1 parent bf75d60 commit faf7bd2

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

.changeset/ten-pandas-decide.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@khanacademy/wonder-blocks-data": patch
3+
---
4+
5+
Version bump to verify release protections

.github/workflows/node-ci-pr.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,6 @@ jobs:
147147
id: get-run-url
148148
run: echo "run_url=https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" >> $GITHUB_OUTPUT
149149

150-
151150
# We need to see if any releases are in progress.
152151
# We do not want to try and publish anything if a publish is
153152
# pending. We fail here, but we make sure to update the
@@ -160,7 +159,7 @@ jobs:
160159
# Releases are triggered by merging "Version Packages" PRs.
161160
# So we look for instances of the release.yml workflow, with
162161
# a title containing "Version Packages", that are in progress.
163-
release_count=$(gh run list --workflow release.yml --json status,displayTitle --jq '[.[] | select(.status == "in_progress" and (.displayTitle | contains("Version Packages")))] | length')
162+
release_count=$(gh run list --workflow release.yml --json status,displayTitle --jq '[.[] | select(.status == "in_progress" and ((.displayTitle | contains("Version Packages")) or (.displayTitle | contains("RELEASING:"))))] | length')
164163
echo "release_count=$release_count" >> $GITHUB_OUTPUT
165164
if [ "$release_count" -ne 0 ]; then
166165
echo "Error: There are $release_count releases in progress."

0 commit comments

Comments
 (0)