You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[SR][Pi ticks] Add a coefficient before pi-based values that start with negative pi (#2401)
## Summary:
We need to add `1` coefficient before pi-based values that start with negative pi,
because screen readers may not read the `-` sign, implying the value is positive
even when it's not.
By adding the `1`, it will read "minus one pi" which is at least correct in terms
of meaning, even if it doesn't totally match the spoken vocabulary.
In the [Slack conversation about this](https://khanacademy.slack.com/archives/C067UM1QAR4/p1744829758895619), I received confirmation from Charlie that
this is an acceptable approach.
Issue: https://khanacademy.atlassian.net/browse/LEMS-3041
## Test plan:
`pnpm jest packages/perseus/src/widgets/interactive-graphs/graphs/screenreader-text.test.ts`
Storybook
- Go to http://localhost:6006/iframe.html?globals=&args=&id=perseuseditor-widgets-interactive-graph--interactive-graph-sinusoid-with-pi-ticks&viewMode=story
- Move a point to an x value of -pi
- Turn on a screen reader and navigate to the point
- Confirm that it reads as "minus one pi" and NOT "pi"
Author: nishasy
Reviewers: jeremywiebe
Required Reviewers:
Approved By: jeremywiebe
Checks: ✅ 8 checks were successful
Pull Request URL: #2401
0 commit comments