Fix radio widget parser types (#2378)

## Summary:
The types for the migration functions were wrong; I think typechecking was
still passing because `PerseusRadioWidgetOptions` is the union of all the
various versions, and most of its fields are optional.

Issue: none

## Test plan:

`pnpm tsc`

Author: benchristel

Reviewers: jeremywiebe, benchristel, handeyeco, Myranae

Required Reviewers:

Approved By: jeremywiebe

Checks: ✅ 8 checks were successful

Pull Request URL: #2378

Author: benchristel

.changeset/tidy-balloons-hammer.md

@@ -0,0 +1,7 @@
+---
+"@khanacademy/perseus-core": patch
+---
+
+Fix Radio widget parser types; the parser now always sets
+`PerseusRadioWidgetOptions.noneOfTheAbove` to either `false` or `undefined`
+(whereas before it might be missing entirely).

packages/perseus-core/src/parse-perseus-json/perseus-parsers/radio-widget.ts

@@ -15,8 +15,7 @@ import {versionedWidgetOptions} from "./versioned-widget-options";
 import {parseWidgetWithVersion} from "./widget";
 import {parseWidgetsMap} from "./widgets-map";
 
-import type {RadioWidget} from "../../data-schema";
-import type {ParsedValue, Parser} from "../parser-types";
+import type {ParsedValue} from "../parser-types";
 
 const parseWidgetsMapOrUndefined = defaulted(
     // There is an import cycle between radio-widget.ts and
@@ -27,7 +26,7 @@ const parseWidgetsMapOrUndefined = defaulted(
 );
 
 const version2 = optional(object({major: constant(2), minor: number}));
-const parseRadioWidgetV2: Parser<RadioWidget> = parseWidgetWithVersion(
+const parseRadioWidgetV2 = parseWidgetWithVersion(
     version2,
     constant("radio"),
     object({
@@ -58,7 +57,7 @@ const parseRadioWidgetV2: Parser<RadioWidget> = parseWidgetWithVersion(
 );
 
 const version1 = optional(object({major: constant(1), minor: number}));
-const parseRadioWidgetV1: Parser<RadioWidget> = parseWidgetWithVersion(
+const parseRadioWidgetV1 = parseWidgetWithVersion(
     version1,
     constant("radio"),
     object({
@@ -89,7 +88,7 @@ const parseRadioWidgetV1: Parser<RadioWidget> = parseWidgetWithVersion(
 
 function migrateV1ToV2(
     widget: ParsedValue<typeof parseRadioWidgetV1>,
-): RadioWidget {
+): ParsedValue<typeof parseRadioWidgetV2> {
     const {options} = widget;
     return {
         ...widget,
@@ -102,7 +101,7 @@ function migrateV1ToV2(
 }
 
 const version0 = optional(object({major: constant(0), minor: number}));
-const parseRadioWidgetV0: Parser<RadioWidget> = parseWidgetWithVersion(
+const parseRadioWidgetV0 = parseWidgetWithVersion(
     version0,
     constant("radio"),
     object({
@@ -132,8 +131,8 @@ const parseRadioWidgetV0: Parser<RadioWidget> = parseWidgetWithVersion(
 );
 
 function migrateV0ToV1(
-    widget: ParsedValue<typeof parseRadioWidgetV1>,
-): RadioWidget {
+    widget: ParsedValue<typeof parseRadioWidgetV0>,
+): ParsedValue<typeof parseRadioWidgetV1> {
     const {options} = widget;
     const {noneOfTheAbove: _, ...rest} = options;
     return {
@@ -142,13 +141,11 @@ function migrateV0ToV1(
         options: {
             ...rest,
             hasNoneOfTheAbove: false,
+            noneOfTheAbove: undefined,
         },
     };
 }
 
-export const parseRadioWidget: Parser<RadioWidget> = versionedWidgetOptions(
-    2,
-    parseRadioWidgetV2,
-)
+export const parseRadioWidget = versionedWidgetOptions(2, parseRadioWidgetV2)
     .withMigrationFrom(1, parseRadioWidgetV1, migrateV1ToV2)
     .withMigrationFrom(0, parseRadioWidgetV0, migrateV0ToV1).parser;

packages/perseus-core/src/parse-perseus-json/perseus-parsers/radio-widget.typetest.ts

@@ -0,0 +1,8 @@
+import {summon} from "../general-purpose-parsers/test-helpers";
+
+import type {parseRadioWidget} from "./radio-widget";
+import type {RadioWidget} from "../../data-schema";
+import type {ParsedValue} from "../parser-types";
+
+type Parsed = ParsedValue<typeof parseRadioWidget>;
+summon<Parsed>() satisfies RadioWidget;

packages/perseus-core/src/parse-perseus-json/regression-tests/__snapshots__/parse-perseus-json-regression.test.ts.snap

@@ -2996,6 +2996,7 @@ exports[`parseAndMigratePerseusItem given input-number-with-boolean-value.json r
           "displayCount": null,
           "hasNoneOfTheAbove": false,
           "multipleSelect": false,
+          "noneOfTheAbove": undefined,
           "numCorrect": 1,
           "onePerLine": true,
           "randomize": false,
@@ -6988,6 +6989,7 @@ exports[`parseAndMigratePerseusItem given number-line-with-empty-strings-in-labe
           "displayCount": null,
           "hasNoneOfTheAbove": false,
           "multipleSelect": true,
+          "noneOfTheAbove": undefined,
           "numCorrect": 1,
           "onePerLine": true,
           "randomize": true,
@@ -9258,6 +9260,7 @@ exports[`parseAndMigratePerseusItem given orderer-option-missing-widgets.json re
           "displayCount": null,
           "hasNoneOfTheAbove": false,
           "multipleSelect": false,
+          "noneOfTheAbove": undefined,
           "numCorrect": 1,
           "onePerLine": true,
           "randomize": false,
@@ -9775,6 +9778,7 @@ Anton Peffenhauser, *Foot-Combat Armor of Prince-Elector Christian I of Saxony (
           "displayCount": null,
           "hasNoneOfTheAbove": false,
           "multipleSelect": false,
+          "noneOfTheAbove": undefined,
           "numCorrect": 1,
           "onePerLine": true,
           "randomize": false,
@@ -9799,6 +9803,7 @@ Anton Peffenhauser, *Foot-Combat Armor of Prince-Elector Christian I of Saxony (
           "displayCount": null,
           "hasNoneOfTheAbove": false,
           "multipleSelect": false,
+          "noneOfTheAbove": undefined,
           "numCorrect": 0,
           "onePerLine": true,
           "randomize": false,
@@ -10056,6 +10061,7 @@ exports[`parseAndMigratePerseusItem given plotter-with-undefined-plotDimensions.
           "displayCount": null,
           "hasNoneOfTheAbove": false,
           "multipleSelect": false,
+          "noneOfTheAbove": undefined,
           "numCorrect": 1,
           "onePerLine": true,
           "randomize": true,
@@ -10152,6 +10158,7 @@ exports[`parseAndMigratePerseusItem given radio-choice-missing-content.json retu
                 "displayCount": null,
                 "hasNoneOfTheAbove": false,
                 "multipleSelect": false,
+                "noneOfTheAbove": undefined,
                 "numCorrect": 0,
                 "onePerLine": true,
                 "randomize": false,
@@ -10199,6 +10206,7 @@ exports[`parseAndMigratePerseusItem given radio-choice-missing-content.json retu
                 "displayCount": null,
                 "hasNoneOfTheAbove": false,
                 "multipleSelect": false,
+                "noneOfTheAbove": undefined,
                 "numCorrect": 0,
                 "onePerLine": true,
                 "randomize": false,
@@ -10246,6 +10254,7 @@ exports[`parseAndMigratePerseusItem given radio-choice-missing-content.json retu
                 "displayCount": null,
                 "hasNoneOfTheAbove": false,
                 "multipleSelect": false,
+                "noneOfTheAbove": undefined,
                 "numCorrect": 0,
                 "onePerLine": true,
                 "randomize": false,
@@ -10293,6 +10302,7 @@ exports[`parseAndMigratePerseusItem given radio-choice-missing-content.json retu
                 "displayCount": null,
                 "hasNoneOfTheAbove": false,
                 "multipleSelect": false,
+                "noneOfTheAbove": undefined,
                 "numCorrect": 0,
                 "onePerLine": true,
                 "randomize": false,