Skip to content

Commit 3ac541b

Browse files
meixgKhafraDev
authored andcommitted
fix(fetch): makeNetworkError called twice when httpNetworkFetch run error (nodejs#1353)
1 parent 62a92aa commit 3ac541b

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

lib/fetch/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2029,7 +2029,7 @@ async function httpNetworkFetch (
20292029

20302030
fetchParams.controller.terminate(error)
20312031

2032-
reject(makeNetworkError(error))
2032+
reject(error)
20332033
}
20342034
}
20352035
))

test/fetch/client-fetch.js

+10
Original file line numberDiff line numberDiff line change
@@ -332,3 +332,13 @@ test('post FormData with File', (t) => {
332332
t.ok(/filename123/.test(result))
333333
})
334334
})
335+
336+
test('invalid url', async (t) => {
337+
t.plan(1)
338+
339+
try {
340+
await fetch('http://invalid')
341+
} catch (e) {
342+
t.match(e.cause.message, 'invalid')
343+
}
344+
})

0 commit comments

Comments
 (0)