Skip to content

Commit 385fbd2

Browse files
authored
Merge pull request #2863 from JohnDuprey/dev
BEC prettification
2 parents 240772a + 2b4f94a commit 385fbd2

File tree

3 files changed

+50
-34
lines changed

3 files changed

+50
-34
lines changed

src/store/api/users.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ export const usersApi = baseApi.injectEndpoints({
6464
userId: _args.userId,
6565
tenantFilter: _args.tenantFilter,
6666
userName: _args.userName,
67+
overwrite: _args.overwrite,
6768
},
6869
})
6970
if (startRequest.error) {

src/views/email-exchange/administration/QuarantineList.jsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import { MessageViewer } from 'src/views/email-exchange/tools/MessageViewer'
1010
import { ModalService } from 'src/components/utilities'
1111
import { useLazyGenericGetRequestQuery } from 'src/store/api/app'
1212
import PropTypes from 'prop-types'
13+
import Skeleton from 'react-loading-skeleton'
1314

1415
const QuarantineList = () => {
1516
const tenant = useSelector((state) => state.app.currentTenant)
@@ -95,11 +96,7 @@ const QuarantineList = () => {
9596
placement="end"
9697
>
9798
<>
98-
{quarantineMessage.isLoading && (
99-
<div>
100-
<CSpinner className="me-2" /> Loading message
101-
</div>
102-
)}
99+
{quarantineMessage.isLoading && <Skeleton count={10} height={30} />}
103100
{quarantineMessage.isSuccess && (
104101
<MessageViewer emailSource={quarantineMessage?.data?.Message} />
105102
)}

src/views/identity/administration/ViewBEC.jsx

Lines changed: 47 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import { CippContentCard, CippMasonry, CippMasonryItem, CippPage } from 'src/com
2222
import 'react-loading-skeleton/dist/skeleton.css'
2323
import Skeleton from 'react-loading-skeleton'
2424
import useConfirmModal from 'src/hooks/useConfirmModal'
25+
import { cellGenericFormatter } from 'src/components/tables/CellGenericFormat'
2526

2627
const ViewBec = () => {
2728
let query = useQuery()
@@ -85,28 +86,33 @@ const ViewBec = () => {
8586
const logonColumns = [
8687
{
8788
name: 'App',
88-
selector: (row) => row['AppDisplayName'],
89+
selector: (row) => row['appDisplayName'],
8990
sortable: true,
91+
cell: cellGenericFormatter(),
9092
},
9193
{
9294
name: 'Date Time',
93-
selector: (row) => row['CreatedDateTime'],
95+
selector: (row) => row['createdDateTime'],
9496
sortable: true,
97+
cell: cellGenericFormatter(),
9598
},
9699
{
97100
name: 'Error code',
98101
selector: (row) => row.id,
99102
sortable: true,
103+
cell: cellGenericFormatter(),
100104
},
101105
{
102106
name: 'Details',
103107
selector: (row) => row.Status,
104108
sortable: true,
109+
cell: cellGenericFormatter(),
105110
},
106111
{
107112
name: 'IP',
108113
selector: (row) => row.IPAddress,
109114
sortable: true,
115+
cell: cellGenericFormatter(),
110116
},
111117
]
112118

@@ -115,38 +121,45 @@ const ViewBec = () => {
115121
name: 'IP',
116122
selector: (row) => row['IPAddress'],
117123
sortable: true,
124+
cell: cellGenericFormatter(),
118125
},
119126
{
120127
name: 'User',
121128
selector: (row) => row['userPrincipalName'],
122129
sortable: true,
130+
cell: cellGenericFormatter(),
123131
},
124132
{
125133
name: 'Application',
126134
selector: (row) => row['AppDisplayName'],
127135
sortable: true,
136+
cell: cellGenericFormatter(),
128137
},
129138
{
130139
name: 'Result',
131140
selector: (row) => row['Status'],
132141
sortable: true,
142+
cell: cellGenericFormatter(),
133143
},
134144
]
135145
const newUserColumns = [
136146
{
137147
name: 'DisplayName',
138148
selector: (row) => row['displayName'],
139149
sortable: true,
150+
cell: cellGenericFormatter(),
140151
},
141152
{
142153
name: 'Username',
143154
selector: (row) => row['userPrincipalName'],
144155
sortable: true,
156+
cell: cellGenericFormatter(),
145157
},
146158
{
147159
name: 'Date',
148-
selector: (row) => row['CreatedDateTime'],
160+
selector: (row) => row['createdDateTime'],
149161
sortable: true,
162+
cell: cellGenericFormatter(),
150163
},
151164
]
152165

@@ -155,16 +168,19 @@ const ViewBec = () => {
155168
name: 'displayName',
156169
selector: (row) => row['displayName'],
157170
sortable: true,
171+
cell: cellGenericFormatter(),
158172
},
159173
{
160174
name: 'Username',
161175
selector: (row) => row['userPrincipalName'],
162176
sortable: true,
177+
cell: cellGenericFormatter(),
163178
},
164179
{
165180
name: 'Date',
166181
selector: (row) => row['lastPasswordChangeDateTime'],
167182
sortable: true,
183+
cell: cellGenericFormatter(),
168184
},
169185
]
170186

@@ -173,44 +189,46 @@ const ViewBec = () => {
173189
name: 'Operation',
174190
selector: (row) => row['Operation'],
175191
sortable: true,
192+
cell: cellGenericFormatter(),
176193
},
177194
{
178195
name: 'Executed by',
179196
selector: (row) => row['UserKey'],
180197
sortable: true,
198+
cell: cellGenericFormatter(),
181199
},
182200
{
183201
name: 'Executed on',
184202
selector: (row) => row['ObjectId'],
185203
sortable: true,
204+
cell: cellGenericFormatter(),
186205
},
187206
{
188207
name: 'Permissions',
189208
selector: (row) => row['Permissions'],
190209
sortable: true,
210+
cell: cellGenericFormatter(),
191211
},
192212
]
193213

194214
const appColumns = [
195215
{
196-
name: 'Type',
197-
selector: (row) => row['Operation'],
198-
sortable: true,
199-
},
200-
{
201-
name: 'User',
202-
selector: (row) => row['UserId'],
216+
name: 'Application',
217+
selector: (row) => row['appDisplayName'],
203218
sortable: true,
219+
cell: cellGenericFormatter(),
204220
},
205221
{
206-
name: 'Application',
207-
selector: (row) => row['ObjectId'],
222+
name: 'Application ID',
223+
selector: (row) => row['appId'],
208224
sortable: true,
225+
cell: cellGenericFormatter(),
209226
},
210227
{
211-
name: 'Result',
212-
selector: (row) => row['ResultStatus'],
228+
name: 'Created',
229+
selector: (row) => row['createdDateTime'],
213230
sortable: true,
231+
cell: cellGenericFormatter(),
214232
},
215233
]
216234
const handleReMediate = useConfirmModal({
@@ -304,9 +322,9 @@ const ViewBec = () => {
304322
data={alerts.SuspectUserDevices}
305323
striped
306324
responsive={true}
307-
tableProps={{ subHeaderComponent: false, pagination: false }}
325+
isModal={true}
308326
wrapperClasses="table-responsive"
309-
reportName="none"
327+
reportName="bec-user-devices"
310328
/>
311329
)}
312330
</CippContentCard>
@@ -322,8 +340,8 @@ const ViewBec = () => {
322340
data={alerts.NewRules}
323341
striped
324342
responsive={true}
325-
tableProps={{ subHeaderComponent: false }}
326-
reportName="none"
343+
isModal={true}
344+
reportName="bec-inbox-rules"
327345
/>
328346
)}
329347
</CippContentCard>
@@ -338,8 +356,8 @@ const ViewBec = () => {
338356
data={alerts.LastSuspectUserLogon}
339357
striped
340358
responsive={true}
341-
tableProps={{ subHeaderComponent: false }}
342-
reportName="none"
359+
isModal={true}
360+
reportName="bec-suspect-user-logons"
343361
/>
344362
)}
345363
</CippContentCard>
@@ -355,9 +373,9 @@ const ViewBec = () => {
355373
data={alerts.NewUsers}
356374
striped
357375
responsive={true}
358-
tableProps={{ subHeaderComponent: false }}
376+
isModal={true}
359377
wrapperClasses="table-responsive"
360-
reportName="none"
378+
reportName="bec-new-users"
361379
/>
362380
)}
363381
</CippContentCard>
@@ -373,9 +391,9 @@ const ViewBec = () => {
373391
data={alerts.ChangedPasswords}
374392
striped
375393
responsive={true}
376-
tableProps={{ subHeaderComponent: false }}
394+
isModal={true}
377395
wrapperClasses="table-responsive"
378-
reportName="none"
396+
reportName="bec-changed-passwords"
379397
/>
380398
)}
381399
</CippContentCard>
@@ -391,9 +409,9 @@ const ViewBec = () => {
391409
data={alerts.MailboxPermissionChanges}
392410
striped
393411
responsive={true}
394-
tableProps={{ subHeaderComponent: false }}
412+
isModal={true}
395413
wrapperClasses="table-responsive"
396-
reportName="none"
414+
reportName="bec-mailbox-permission-changes"
397415
/>
398416
)}
399417
</CippContentCard>
@@ -409,9 +427,9 @@ const ViewBec = () => {
409427
data={alerts.AddedApps}
410428
striped
411429
responsive={true}
412-
tableProps={{ subHeaderComponent: false }}
413430
wrapperClasses="table-responsive"
414-
reportName="none"
431+
isModal={true}
432+
reportName="bec-added-apps"
415433
/>
416434
)}
417435
</CippContentCard>
@@ -427,7 +445,7 @@ const ViewBec = () => {
427445
data={alerts.SuspectUserMailboxLogons}
428446
striped
429447
responsive={true}
430-
tableProps={{ subHeaderComponent: false }}
448+
isModal={true}
431449
wrapperClasses="table-responsive"
432450
reportName="none"
433451
/>

0 commit comments

Comments
 (0)