Skip to content

Commit 006ccf3

Browse files
author
Shuotian Cheng
authored
[config]: Move setting GRE/queue for mirror session as optional (sonic-net#314)
GRE type and queue number could be set internally if not specified by the user. Signed-off-by: Shu0T1an ChenG <[email protected]>
1 parent 98add9e commit 006ccf3

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

config/main.py

+10-6
Original file line numberDiff line numberDiff line change
@@ -353,11 +353,11 @@ def mirror_session():
353353
@click.argument('session_name', metavar='<session_name>', required=True)
354354
@click.argument('src_ip', metavar='<src_ip>', required=True)
355355
@click.argument('dst_ip', metavar='<dst_ip>', required=True)
356-
@click.argument('gre_type', metavar='<gre_type>', required=True)
357356
@click.argument('dscp', metavar='<dscp>', required=True)
358357
@click.argument('ttl', metavar='<ttl>', required=True)
359-
@click.argument('queue', metavar='<queue>', required=True)
360-
def add(session_name, src_ip, dst_ip, gre_type, dscp, ttl, queue):
358+
@click.argument('gre_type', metavar='[gre_type]', required=False)
359+
@click.argument('queue', metavar='[queue]', required=False)
360+
def add(session_name, src_ip, dst_ip, dscp, ttl, gre_type, queue):
361361
"""
362362
Add mirror session
363363
"""
@@ -367,12 +367,16 @@ def add(session_name, src_ip, dst_ip, gre_type, dscp, ttl, queue):
367367
session_info = {
368368
"src_ip": src_ip,
369369
"dst_ip": dst_ip,
370-
"gre_type": gre_type,
371370
"dscp": dscp,
372-
"ttl": ttl,
373-
"queue": queue
371+
"ttl": ttl
374372
}
375373

374+
if gre_type is not None:
375+
session_info['gre_type'] = gre_type
376+
377+
if queue is not None:
378+
session_info['queue'] = queue
379+
376380
config_db.set_entry("MIRROR_SESSION", session_name, session_info)
377381

378382
@mirror_session.command()

0 commit comments

Comments
 (0)