Skip to content

Issues with wrapper scripts on the juliaecosysten macOS CI machines #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maleadt opened this issue Feb 22, 2023 · 11 comments · Fixed by JuliaPackaging/Yggdrasil#6302 or JuliaPackaging/Yggdrasil#6303

Comments

@maleadt
Copy link

maleadt commented Feb 22, 2023

After the introduction of the wrapper scripts, use of Git.jl/Git_jll.jl in Metal.jl fails: https://buildkite.com/julialang/metal-dot-jl/builds/256#01867a01-961b-4ad4-a462-803f7078d9d7

readlink: illegal option -- f
usage: readlink [-n] [file ...]
usage: dirname string [...]
/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/6a8cdbf9e758f66cee5f4f87fa20eb9be7521865/bin/git: line 5: /Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/build/default-macmini-aarch64-1-0/julialang/metal-dot-jl/_git: No such file or directory
/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/6a8cdbf9e758f66cee5f4f87fa20eb9be7521865/bin/git: line 5: exec: /Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/build/default-macmini-aarch64-1-0/julialang/metal-dot-jl/_git: cannot execute: No such file or directory
ERROR: LoadError: failed process: Process(setenv(`/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/6a8cdbf9e758f66cee5f4f87fa20eb9be7521865/bin/git -C /Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/build/default-macmini-aarch64-1-0/julialang/metal-dot-jl/deps log -1 --format=%ct cmt`,["PATH=/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/41d2d4f312d93b56961767987cf48ea1f6d6fadc/bin:/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/b1a055a9c307b137556560efcc2cee3a6405dfd7/bin:/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/6a8cdbf9e758f66cee5f4f87fa20eb9be7521865/bin:/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/julia_installs/bin/macos/aarch64/1.9/julia-latest-macos-aarch64/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/bin:/sbin:/Users/administrator/.julia/artifacts/a81c923ea521c5513024eec57507055e4daa978a", "BUILDKITE_BUILD_CREATOR_TEAMS=committers-at-julialang-slash-committers", "BUILDKITE_LAST_HOOK_EXIT_STATUS=0", "BUILDKITE_PROJECT_PROVIDER=github", "GKS_ENCODING=utf8", "SECRET_CODECOV_TOKEN=[REDACTED]", "BASH_FUNC_nproc%%=() {  sysctl -n \"hw.perflevel0.logicalcpu\"\n}", "BUILDKITE_BUILD_CREATOR=Tim Besard", "BUILDKITE_REPO_MIRROR=/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/repos/https---g.yxqyang.asia-JuliaGPU-Metal-jl-git", "BUILDKITE_AGENT_META_DATA_NUM_CPUS=4"  …  "BUILDKITE_STEP_ID=01867a01-95ea-4f86-b65c-2e224efc44dc", "CI=true", "BUILDKITE_STEP_KEY=", "BUILDKITE_TAG=", "BUILDKITE_LABEL=Julia 1.9", "BUILDKITE_COMMIT=dd2be50b81e793c47b19592d4baee5c84ecaaf53", "BUILDKITE_PULL_REQUEST=85", "BUILDKITE_AGENT_PID=37308", "GIT_SSL_CAINFO=/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/julia_installs/bin/macos/aarch64/1.9/julia-latest-macos-aarch64/share/julia/cert.pem", "OPENBLAS_MAIN_FREE=1"]), ProcessExited(126)) [126]

Looks like the readlink -f is a GNUism.

@maleadt
Copy link
Author

maleadt commented Feb 23, 2023

Still broken

/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/ea7c742fe85919b2af7a76ed5e9a8abd3d9812a1/libexec/git-core/git: line 5: /Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/ea7c742fe85919b2af7a76ed5e9a8abd3d9812a1/libexec/git-core/_git: No such file or directory
/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/ea7c742fe85919b2af7a76ed5e9a8abd3d9812a1/libexec/git-core/git: line 5: exec: /Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/ea7c742fe85919b2af7a76ed5e9a8abd3d9812a1/libexec/git-core/_git: cannot execute: No such file or directory
ERROR: LoadError: failed process: Process(setenv(`/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/ea7c742fe85919b2af7a76ed5e9a8abd3d9812a1/bin/git clone -q https://github.com/JuliaBinaryWrappers/cmt_jll.jl /private/var/tmp/agent-tempdirs/default-macmini-aarch64-1.0/tmp/jl_Vj4ZPS`,["PATH=/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/41d2d4f312d93b56961767987cf48ea1f6d6fadc/bin:/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/b1a055a9c307b137556560efcc2cee3a6405dfd7/bin:/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/depots/5cd495a2-4a16-4674-ae02-c839447744bb/artifacts/ea7c742fe85919b2af7a76ed5e9a8abd3d9812a1/bin:/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/julia_installs/bin/macos/aarch64/1.9/julia-latest-macos-aarch64/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/bin:/sbin:/Users/administrator/.julia/artifacts/a81c923ea521c5513024eec57507055e4daa978a", "BUILDKITE_BUILD_CREATOR_TEAMS=committers-at-julialang-slash-committers", "BUILDKITE_LAST_HOOK_EXIT_STATUS=0", "BUILDKITE_PROJECT_PROVIDER=github", "GKS_ENCODING=utf8", "SECRET_CODECOV_TOKEN=[REDACTED]", "BASH_FUNC_nproc%%=() {  sysctl -n \"hw.perflevel0.logicalcpu\"\n}", "BUILDKITE_BUILD_CREATOR=Tim Besard", "BUILDKITE_REPO_MIRROR=/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/repos/https---g.yxqyang.asia-JuliaGPU-Metal-jl-git", "BUILDKITE_AGENT_META_DATA_NUM_CPUS=4"  …  "BUILDKITE_STEP_ID=01867a01-95ea-4f86-b65c-2e224efc44dc", "CI=true", "BUILDKITE_STEP_KEY=", "BUILDKITE_TAG=", "BUILDKITE_LABEL=Julia 1.9", "BUILDKITE_COMMIT=dd2be50b81e793c47b19592d4baee5c84ecaaf53", "BUILDKITE_PULL_REQUEST=85", "BUILDKITE_AGENT_PID=39747", "GIT_SSL_CAINFO=/Users/administrator/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-macmini-aarch64-1.0/julia_installs/bin/macos/aarch64/1.9/julia-latest-macos-aarch64/share/julia/cert.pem", "OPENBLAS_MAIN_FREE=1"]), ProcessExited(128)) [128]

Can't we revert these changes until we have something that works?

@giordano
Copy link
Member

I mean, tests in #45 and #46 passed, it worked also on my MacBook before JuliaPackaging/Yggdrasil#6302. If anything, we should revert JuliaPackaging/Yggdrasil#6302. I just noticed that my macOS does have readlink -f.

@giordano
Copy link
Member

You can pin to ~1.2 if that works for you, until we iron out these issue.

@maleadt
Copy link
Author

maleadt commented Feb 23, 2023

If anything, we should revert JuliaPackaging/Yggdrasil#6302. I just noticed that my macOS does have readlink -f.

Your macbook might, but the juliaecosystem macos' don't, so I don't get why'd you want to revert that.

@giordano
Copy link
Member

What do you want to revert exactly? Git.jl on macOS has always been broken before JuliaPackaging/Yggdrasil#4987, there isn't a working status for everyone anyway.

@maleadt
Copy link
Author

maleadt commented Feb 23, 2023

Git.jl on macOS has always been broken before JuliaPackaging/Yggdrasil#4987, there isn't a working status for everyone anyway.

That's weird, I had been successfully using it on macOS CI for Metal.jl. But yeah, pinning works for now, so that's fine for me.

@DilumAluthge
Copy link
Member

@staticfloat Any idea why the Juliaecosystem machines specifically would be having problems? Something with our Seatbelt setup?

@DilumAluthge DilumAluthge reopened this Feb 23, 2023
@DilumAluthge DilumAluthge changed the title Issues with wrapper scripts on macOS Issues with wrapper scripts on the juliaecosysten macOS CI machines Feb 23, 2023
@giordano
Copy link
Member

This will be fixed by JuliaPackaging/Yggdrasil#6303, if anyone cares to review it.

@staticfloat
Copy link
Contributor

Thanks Mosè!

@DilumAluthge
Copy link
Member

@staticfloat @giordano Can we add a test for this issue somewhere in the Git.jl test suite?

@giordano
Copy link
Member

The entire test suite is doing that already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants