[GettextRuntime] Make gettext-runtime its own package #11038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps @giordano should chime in given the original issue about using Gettext_jll as a BuildDependency. In the meanwhile, might as well update this to 0.25. |
|
I need to test that Makie still works with this instead of the current |
|
Makie works on Linux using Glib built with GettextRuntime_jll, but on Windows I get
This is when I run: using Pkg
Pkg.activate(;temp=true)
Pkg.add([
(;url="https://github.com/nhz2/GettextRuntime_jll.jl", rev="02e0a8c"),
(;url="https://github.com/nhz2/Glib_jll.jl", rev="be9f964"),
(;name="CairoMakie"),
]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11030
These are the parts of gettext that are useful at runtime. Unlike the current
Gettext_jll, this package doesn't depend onCompilerSupportLibraries_jllorXML2_jll.