Make user the initial vector defaults to a float type and avoid using

eltype(A) if possible.

Fixes #9

Author: andreasnoack

src/TSVD.jl

@@ -1,4 +1,7 @@
 # Copyright 2015-2018 Andreas Noack
+
+__precompile__()
+
 module TSVD
 
     export tsvd

src/svd.jl

@@ -5,7 +5,7 @@ function biLanczosIterations(A, stepsize, αs, βs, U, V, μs, νs, τ, reorth_i
     nReorth = 0
     nReorthVecs = 0
 
-    T = eltype(A)
+    T = eltype(eltype(U))
     Tr = real(T)
 
     maxνs = Tr[]
@@ -112,7 +112,7 @@ end
 function _tsvd(A,
     nvals = 1;
     maxiter = 1000,
-    initvec = convert(Vector{eltype(A)}, randn(size(A,1))),
+    initvec = convert(Vector{float(eltype(A))}, randn(size(A,1))),
     tolconv = sqrt(eps(real(eltype(initvec)))),
     tolreorth = sqrt(eps(real(eltype(initvec)))),
     stepsize = max(1, div(nvals, 10)),
@@ -330,7 +330,7 @@ julia> s
 tsvd(A,
     nvals = 1;
     maxiter = 1000,
-    initvec = convert(Vector{eltype(A)}, randn(size(A,1))),
+    initvec = convert(Vector{float(eltype(A))}, randn(size(A,1))),
     tolconv = sqrt(eps(real(eltype(initvec)))),
     tolreorth = sqrt(eps(real(eltype(initvec)))),
     stepsize = max(1, div(nvals, 10)),
@@ -378,7 +378,7 @@ end
 
 function tsvd2(A,
     nvals = 1;
-    maxiter = minimum(size(A)),
+    maxiter = min(size(A)...),
     initvec = convert(Vector{eltype(A)}, randn(size(A,2))),
     tolconv = sqrt(eps(real(eltype(A)))),
     stepsize = max(1, div(nvals, 10)),

test/runtests.jl

@@ -1,7 +1,7 @@
 using TSVD
 using Base.Test
 
-for (m, n, p) = ((10, 6, 0.8), (100, 60, 0.1))
+@testset "test tsvd with m = $m, n = $n, and p = $p" for (m, n, p) = ((10, 6, 0.8), (100, 60, 0.1))
     mnp = round(Integer, m*n*p)
 
     for A in (randn(m, n),
@@ -25,3 +25,8 @@ for (m, n, p) = ((10, 6, 0.8), (100, 60, 0.1))
         end
     end
 end
+
+@testset "Issue 9" begin
+    data = rand(1:100, 50, 50)
+    TSVD.tsvd(data,2)
+end