Skip to content

Commit d3f30bb

Browse files
authored
Julia v1.11 Support (#66)
* Julia v1.11 Support * Fix checksingular
1 parent bbaf308 commit d3f30bb

File tree

4 files changed

+16
-6
lines changed

4 files changed

+16
-6
lines changed

.github/workflows/ci.yml

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ jobs:
2222
version:
2323
- '1.9'
2424
- '1'
25+
- '^1.11.0-0'
2526
os:
2627
- ubuntu-latest
2728
- macOS-latest

Project.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name = "MatrixFactorizations"
22
uuid = "a3b82374-2e81-5b9e-98ce-41277c0e4c87"
3-
version = "3.0.0"
3+
version = "3.0.1"
44

55
[deps]
66
ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

src/ul.jl

+3-1
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,11 @@ end
101101

102102
if VERSION < v"1.7-"
103103
_checknonsingular(info, ::Val{Pivot}) where Pivot = checknonsingular(info, Val{Pivot}())
104-
else
104+
elseif VERSION < v"1.11-"
105105
_checknonsingular(info, ::Val{true}) = checknonsingular(info, RowMaximum())
106106
_checknonsingular(info, ::Val{false}) = checknonsingular(info, NoPivot())
107+
else
108+
_checknonsingular(info, _) = checknonsingular(info)
107109
end
108110

109111
"""

test/test_ul.jl

+11-4
Original file line numberDiff line numberDiff line change
@@ -197,10 +197,17 @@ using LinearAlgebra: ldiv!, BlasReal, BlasInt, BlasFloat, rdiv!
197197
@test_throws SingularException ul!(copy(A); check = true)
198198
@test !issuccess(ul(A; check = false))
199199
@test !issuccess(ul!(copy(A); check = false))
200-
@test_throws ZeroPivotException ul(A, Val(false))
201-
@test_throws ZeroPivotException ul!(copy(A), Val(false))
202-
@test_throws ZeroPivotException ul(A, Val(false); check = true)
203-
@test_throws ZeroPivotException ul!(copy(A), Val(false); check = true)
200+
if VERSION < v"1.11-"
201+
@test_throws ZeroPivotException ul(A, Val(false))
202+
@test_throws ZeroPivotException ul!(copy(A), Val(false))
203+
@test_throws ZeroPivotException ul(A, Val(false); check = true)
204+
@test_throws ZeroPivotException ul!(copy(A), Val(false); check = true)
205+
else
206+
@test_throws SingularException ul(A, Val(false))
207+
@test_throws SingularException ul!(copy(A), Val(false))
208+
@test_throws SingularException ul(A, Val(false); check = true)
209+
@test_throws SingularException ul!(copy(A), Val(false); check = true)
210+
end
204211
@test !issuccess(ul(A, Val(false); check = false))
205212
@test !issuccess(ul!(copy(A), Val(false); check = false))
206213
F = ul(A; check = false)

0 commit comments

Comments
 (0)