Skip to content

Commit 227b954

Browse files
committed
rm uniformscaling addition/subtraction specializations?
1 parent 86e5aae commit 227b954

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

ext/ArrayLayoutsFillArraysExt.jl

-14
Original file line numberDiff line numberDiff line change
@@ -88,20 +88,6 @@ sub_materialize(::OnesLayout, V, ax) = Ones{eltype(V)}(ax)
8888
@inline LinearAlgebra.dot(a::LayoutVector, b::AbstractFill{<:Any,1}) = FillArrays._fill_dot_rev(a,b)
8989
@inline LinearAlgebra.dot(a::AbstractFill{<:Any,1}, b::LayoutVector) = FillArrays._fill_dot(a,b)
9090

91-
# TODO: Remove unnecessary _apply
92-
_apply(_, _, op, Λ::UniformScaling, A::AbstractMatrix) = op(Diagonal(Fill.λ,(axes(A,1),))), A)
93-
_apply(_, _, op, A::AbstractMatrix, Λ::UniformScaling) = op(A, Diagonal(Fill.λ,(axes(A,1),))))
94-
95-
for Typ in (:LayoutMatrix, :(Symmetric{<:Any,<:LayoutMatrix}), :(Hermitian{<:Any,<:LayoutMatrix}),
96-
:(Adjoint{<:Any,<:LayoutMatrix}), :(Transpose{<:Any,<:LayoutMatrix}))
97-
@eval begin
98-
@inline +(A::$Typ, Λ::UniformScaling) = _apply(MemoryLayout(A), size(A), +, A, Λ)
99-
@inline +::UniformScaling, A::$Typ) = _apply(MemoryLayout(A), size(A), +, Λ, A)
100-
@inline -(A::$Typ, Λ::UniformScaling) = _apply(MemoryLayout(A), size(A), -, A, Λ)
101-
@inline -::UniformScaling, A::$Typ) = _apply(MemoryLayout(A), size(A), -, Λ, A)
102-
end
103-
end
104-
10591
# equivalent to rescaling
10692
function materialize!(M::MulAdd{<:DiagonalLayout{<:AbstractFillLayout}})
10793
checkdimensions(M)

0 commit comments

Comments
 (0)