Skip to content

Documentation search result regression #52977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LilithHafner opened this issue Jan 19, 2024 · 1 comment
Open

Documentation search result regression #52977

LilithHafner opened this issue Jan 19, 2024 · 1 comment
Labels
docsystem The documentation building system regression Regression in behavior compared to a previous version

Comments

@LilithHafner
Copy link
Member

In 1.10, the search "threading" lists https://docs.julialang.org/en/v1.10/base/multi-threading/ first while in 1.11, it lists https://docs.julialang.org/en/v1.11-dev/NEWS/#Multi-threading-changes, https://docs.julialang.org/en/v1.11-dev/devdocs/locks/#Proper-maintenance-and-care-of-multi-threading-locks, and then https://docs.julialang.org/en/v1.11-dev/devdocs/locks/

It seems pretty clear to me that a manual page with an exact keyword match in it's title should rank first while it currently ranks 5th. I think this is a case-sensitivity bug upstream: JuliaDocs/Documenter.jl#2373

1.10:
Screenshot from 2024-01-19 09-24-41

master:
Screenshot from 2024-01-19 09-25-01

@Hetarth02 changed the Documenter.jl search engine from LunrJs to MinisearchJs in JuliaDocs/Documenter.jl#2172. According to https://hetarth02.hashnode.dev/crafting-an-enhanced-search-experience this seems like a good change overall.

We down streamed those changes into the Julia repo in #47105

@LilithHafner LilithHafner added regression Regression in behavior compared to a previous version docsystem The documentation building system labels Jan 19, 2024
@Hetarth02
Copy link

Hetarth02 commented Jan 19, 2024

Yes, I also think this might be a case sensitivity issue and there are PRs in work to fix this. I hope to close them as soon as possible.

PR #2374

PR #2375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docsystem The documentation building system regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

2 participants