Skip to content

Normalize macOS version #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

Normalize macOS version #61

merged 3 commits into from
Jun 24, 2025

Conversation

christiangnrd
Copy link
Contributor

Return 26 when 16 is reported by default

Copy link
Contributor

github-actions bot commented Jun 23, 2025

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/version.jl b/src/version.jl
index 90c175d..abaf2af 100644
--- a/src/version.jl
+++ b/src/version.jl
@@ -44,13 +44,13 @@ else
     end
 end
 
-function macos_version(normalize=true)
+function macos_version(normalize = true)
     ver = _macos_version()
     if normalize && ver.major == 16
         # on older SDKs, macOS Tahoe (26) is reported as v16.
         # normalize this to v26 regardless of the SDK to simplify use.
         return VersionNumber(26, ver.minor, ver.patch)
-    end    
+    end
     return ver
 end
 @doc """

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.74%. Comparing base (6911018) to head (153cbdc).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
src/version.jl 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   71.91%   77.74%   +5.83%     
==========================================
  Files          10       13       +3     
  Lines         769      993     +224     
==========================================
+ Hits          553      772     +219     
- Misses        216      221       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christiangnrd
Copy link
Contributor Author

Test failures unrelated. (See #53)

@christiangnrd christiangnrd mentioned this pull request Jun 24, 2025
2 tasks
Co-authored-by: Tim Besard <[email protected]>
@christiangnrd christiangnrd requested a review from maleadt June 24, 2025 14:51
@maleadt maleadt merged commit 85c11a0 into JuliaInterop:master Jun 24, 2025
7 checks passed
@christiangnrd christiangnrd deleted the tahoe branch June 24, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants